chrome/renderer/printing/print_web_view_helper_mac.mm - Issue 510253002: Try to use URL and title of the printed frame for header and footer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper_mac.mm

Issue 510253002: Try to use URL and title of the printed frame for header and footer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Thu Aug 28 00:07:06 PDT 2014 Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/printing/print_web_view_helper_linux.cc ('k') | chrome/renderer/printing/print_web_view_helper_pdf_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/printing/print_web_view_helper_mac.mm

diff --git a/chrome/renderer/printing/print_web_view_helper_mac.mm b/chrome/renderer/printing/print_web_view_helper_mac.mm

index 071b7e5c4d14102ce283174cb5b7517ab2c64034..207eea7363d83fdde1bfed33ceaf55445c3a1e15 100644

--- a/chrome/renderer/printing/print_web_view_helper_mac.mm

+++ b/chrome/renderer/printing/print_web_view_helper_mac.mm

@@ -130,11 +130,14 @@ void PrintWebViewHelper::RenderPage(

skia::SetIsDraftMode(*canvas, is_print_ready_metafile_sent_);

skia::SetIsPreviewMetafile(*canvas, is_preview);

- if (print_pages_params_->params.display_header_footer) {

- PrintHeaderAndFooter(canvas_ptr, page_number + 1,

+ if (params.display_header_footer) {

+ PrintHeaderAndFooter(canvas_ptr,

+ page_number + 1,

print_preview_context_.total_page_count(),

- scale_factor, page_layout_in_points,

- *header_footer_info_, params);

+ *frame,

+ scale_factor,

+ page_layout_in_points,

+ params);

}

RenderPageContent(frame, page_number, canvas_area, content_area,

scale_factor, canvas_ptr);