[Findit] Fix blame for GIT and uptake bug fix.

[Findit] Fix blame for GIT and uptake bug fix.

NOTRY=true

Committed: https://crrev.com/270213ea833b79dff1f9fbdabdeed8628e25b29c
Cr-Commit-Position: refs/heads/master@{#292319}

[aarya, 2014-08-28 01:55:13]

aarya@google.com changed reviewers:
+ aarya@google.com

[aarya, 2014-08-28 01:55:13]

lgtm after fixing nits. no need of another review. fix and commit to both findit
and clusterfuzz repo.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils.py
File tools/findit/crash_utils.py (right):

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:19: THREAD_NUMBER = 5
s/THREAD_NUMBER/MAX_THREADS or something like that.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:27: print threading.current_thread().name, ' is
running task ', task_id
Why print ? Won't this show up in findit results which we don't want.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:58: print thread.name, 'is started'
probably need to remove print to prevent from not showing up in output.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:65: task_id += 1
task_id is not needed. even in debugging, you can just print task['function'],
etc.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:71: for task in tasks:
probably for _ in tasks:

[stgao, 2014-08-28 04:02:08]

Patchset #6 (id:100001) has been deleted

[stgao, 2014-08-28 04:24:38]

As discussed offline, I will address threading issues later in another CL.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils.py
File tools/findit/crash_utils.py (right):

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:19: THREAD_NUMBER = 5
On 2014/08/28 01:55:12, aarya wrote:
> s/THREAD_NUMBER/MAX_THREADS or something like that.

Done.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:27: print threading.current_thread().name, ' is
running task ', task_id
On 2014/08/28 01:55:12, aarya wrote:
> Why print ? Won't this show up in findit results which we don't want.

Removed.
Sorry. That's for debugging.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:58: print thread.name, 'is started'
On 2014/08/28 01:55:12, aarya wrote:
> probably need to remove print to prevent from not showing up in output.

Removed.

https://codereview.chromium.org/510163002/diff/80001/tools/findit/crash_utils...
tools/findit/crash_utils.py:71: for task in tasks:
On 2014/08/28 01:55:12, aarya wrote:
> probably for _ in tasks: 

Done.

[stgao, 2014-08-28 04:25:28]

The CQ bit was checked by stgao@chromium.org

[commit-bot: I haz the power, 2014-08-28 04:25:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/stgao@chromium.org/510163002/140001

[commit-bot: I haz the power, 2014-08-28 04:26:37]

Committed patchset #7 (id:140001) as 3b1cc01ff1d8f33213b8dab0ab847a224bd65266

[commit-bot: I haz the power, 2014-09-10 02:57:29]

Patchset 7 (id:??) landed as
https://crrev.com/270213ea833b79dff1f9fbdabdeed8628e25b29c
Cr-Commit-Position: refs/heads/master@{#292319}