Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/findit/findit_for_crash.py

Issue 510163002: [Findit] Fix blame for GIT and uptake bug fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reupload Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/findit/crash_utils.py ('k') | tools/findit/stacktrace.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/findit/findit_for_crash.py
diff --git a/tools/findit/findit_for_crash.py b/tools/findit/findit_for_crash.py
index 50f12d85618577f291298b69faba15029d205123..09e2671bb82d958a1c767180665158dcac8cab9f 100644
--- a/tools/findit/findit_for_crash.py
+++ b/tools/findit/findit_for_crash.py
@@ -477,8 +477,8 @@ def GenerateReasonForMatches(matches):
pretty_file_names = crash_utils.PrettifyList(file_names)
# Add the reason, break because we took care of the rest of the files.
- file_string += '(%s)' % crash_utils.PrettifyFrameInfo(
- stack_frame_indices, function_list)
+ file_string += ('(and is part of stack %s)' %
+ crash_utils.PrettifyFrameInfo(stack_frame_indices, function_list))
reason.append(file_string % pretty_file_names)
break
@@ -522,8 +522,8 @@ def CombineMatches(matches):
if match.min_distance_info:
file_name, min_crashed_line, min_changed_line = match.min_distance_info
match.reason += \
- ('Minimum distance from crashed line to changed line: %d. '
- '(File: %s, Crashed on: %d, Changed: %d).\n' %
+ ('\nMinimum distance from crash line to modified line: %d. '
+ '(file: %s, crashed on: %d, modified: %d).\n' %
(match.min_distance, file_name, min_crashed_line, min_changed_line))
return combined_matches
@@ -668,8 +668,8 @@ def FindItForCrash(stacktrace_list,
if result:
return_message = (
- 'No CL in the regression changes the crashed files. The result is '
- 'the blame information.')
+ 'No CL in the regression range changes the crashed files. '
+ 'The result is the blame information.')
# When findit could not find any CL that changes file in stacktrace or if
# if cannot get any blame information, return a message saying that no
« no previous file with comments | « tools/findit/crash_utils.py ('k') | tools/findit/stacktrace.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698