Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/findit/stacktrace.py

Issue 510163002: [Findit] Fix blame for GIT and uptake bug fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reupload Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/findit/findit_for_crash.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/findit/stacktrace.py
diff --git a/tools/findit/stacktrace.py b/tools/findit/stacktrace.py
index 77d12f9fec0a1438b51c373672b23d74772d6f38..137e6fc92f97bff3707f889a402f84268c0e7357 100644
--- a/tools/findit/stacktrace.py
+++ b/tools/findit/stacktrace.py
@@ -294,6 +294,13 @@ class Stacktrace(object):
# Return a new stack frame object with the parsed information.
file_name = file_path.split('/')[-1]
+
+ # If we have the common stack frame index pattern, then use it
+ # since it is more reliable.
+ index_match = re.match('\s*#(\d+)\s.*', line)
+ if index_match:
+ stack_frame_index = int(index_match.group(1))
+
return StackFrame(stack_frame_index, component_path, component_name,
file_name, function, file_path, crashed_line_range)
« no previous file with comments | « tools/findit/findit_for_crash.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698