Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 509893002: Revert of Remove the last piece of deprecated synchronous IO code. (Closed)

Created:
6 years, 3 months ago by Thiemo Nagel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the last piece of deprecated synchronous IO code. (patchset #5 of https://codereview.chromium.org/460373002/) Reason for revert: Build failure on Google Chrome ChromeOS: http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=71164 Original issue's description: > Remove the last piece of deprecated synchronous IO code. > > BUG=337096 > TEST=bots > > Committed: https://chromium.googlesource.com/chromium/src/+/c4a64ffdd0d511c66d774341fa0a318af7911193 TBR=dalecurtis@chromium.org,ajm@chromium.org,rkc@chromium.org,avi@chromium.org,palmer@chromium.org,xians@chromium.org NOTREECHECKS=true NOTRY=true BUG=337096 Committed: https://crrev.com/688335507909215843b37f201787da80d8b68266 Cr-Commit-Position: refs/heads/master@{#292133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -44 lines) Patch
M components/copresence/mediums/audio/audio_recorder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/copresence/mediums/audio/audio_recorder_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/media_internals.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/media_internals_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/media/media_param_traits.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/media/audio_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webaudio_capturer_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_renderer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_renderer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_track_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/alsa/audio_manager_alsa.cc View 3 chunks +3 lines, -1 line 0 comments Download
M media/audio/android/audio_android_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/audio/audio_output_device.h View 1 chunk +5 lines, -2 lines 0 comments Download
M media/audio/audio_output_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_parameters.h View 5 chunks +12 lines, -2 lines 0 comments Download
M media/audio/audio_parameters.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M media/audio/cras/audio_manager_cras.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/cras/cras_unified.h View 2 chunks +8 lines, -0 lines 0 comments Download
M media/audio/cras/cras_unified.cc View 3 chunks +70 lines, -0 lines 0 comments Download
M media/audio/fake_audio_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 chunk +12 lines, -1 line 0 comments Download
M media/audio/openbsd/audio_manager_openbsd.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/audio_buffer_converter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/audio_buffer_converter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/channel_mixer_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/test/fake_media_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/audio_renderer_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Thiemo Nagel
Created Revert of Remove the last piece of deprecated synchronous IO code.
6 years, 3 months ago (2014-08-27 11:00:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/509893002/1
6 years, 3 months ago (2014-08-27 11:01:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as 3e8c19c89c16fe8a7c2dfe0cae2990cd4a004339
6 years, 3 months ago (2014-08-27 11:02:15 UTC) #3
rkc
I'll fix this today. The ledger repo no longer needs to build since all the ...
6 years, 3 months ago (2014-08-27 11:36:21 UTC) #4
no longer working on chromium
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/518433002/ by xians@chromium.org. The ...
6 years, 3 months ago (2014-08-28 18:14:06 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:51:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/688335507909215843b37f201787da80d8b68266
Cr-Commit-Position: refs/heads/master@{#292133}

Powered by Google App Engine
This is Rietveld 408576698