Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 510893003: Remove ledger code from Chrome (Closed)

Created:
6 years, 3 months ago by rkc
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/447e14fe56fbbcb57a4b195ec8345c5da2afad48 Cr-Commit-Position: refs/heads/master@{#292231}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -61 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/common/extensions/api/schemas.gni View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
rkc
6 years, 3 months ago (2014-08-27 19:20:49 UTC) #1
Nico
rs-lgtm
6 years, 3 months ago (2014-08-27 19:31:58 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/510893003/diff/1/chrome/common/extensions/api/schemas.gypi File chrome/common/extensions/api/schemas.gypi (left): https://codereview.chromium.org/510893003/diff/1/chrome/common/extensions/api/schemas.gypi#oldcode145 chrome/common/extensions/api/schemas.gypi:145: 'chromeos_branded_schema_files': [ Where even is this file? Can we ...
6 years, 3 months ago (2014-08-27 19:36:25 UTC) #3
Ilya Sherman
histograms lgtm
6 years, 3 months ago (2014-08-27 19:41:19 UTC) #4
rkc
https://codereview.chromium.org/510893003/diff/1/chrome/common/extensions/api/schemas.gypi File chrome/common/extensions/api/schemas.gypi (left): https://codereview.chromium.org/510893003/diff/1/chrome/common/extensions/api/schemas.gypi#oldcode145 chrome/common/extensions/api/schemas.gypi:145: 'chromeos_branded_schema_files': [ On 2014/08/27 19:36:25, kalman wrote: > Where ...
6 years, 3 months ago (2014-08-27 19:42:07 UTC) #5
not at google - send to devlin
https://codereview.chromium.org/510893003/diff/1/chrome/common/extensions/api/schemas.gypi File chrome/common/extensions/api/schemas.gypi (left): https://codereview.chromium.org/510893003/diff/1/chrome/common/extensions/api/schemas.gypi#oldcode145 chrome/common/extensions/api/schemas.gypi:145: 'chromeos_branded_schema_files': [ On 2014/08/27 19:42:07, Rahul Chaturvedi wrote: > ...
6 years, 3 months ago (2014-08-27 19:56:55 UTC) #6
not at google - send to devlin
It looks like there are still entries for "ledger" in .gitignore, but other than that, ...
6 years, 3 months ago (2014-08-27 20:10:28 UTC) #7
rkc
On 2014/08/27 20:10:28, kalman wrote: > It looks like there are still entries for "ledger" ...
6 years, 3 months ago (2014-08-27 20:18:02 UTC) #8
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 3 months ago (2014-08-27 20:18:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/510893003/20001
6 years, 3 months ago (2014-08-27 20:19:04 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-27 21:31:26 UTC) #11
rkc
Committed patchset #2 (id:20001) to pending queue manually as 83dc94e (presubmit successful).
6 years, 3 months ago (2014-08-27 21:35:37 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/447e14fe56fbbcb57a4b195ec8345c5da2afad48
Cr-Commit-Position: refs/heads/master@{#292231}

Powered by Google App Engine
This is Rietveld 408576698