Issue 509173003: Omnibox.mojom: make input_string non-nullable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 509173003: Omnibox.mojom: make input_string non-nullable. (Closed)

Created:
6 years, 3 months ago by yzshen1

Modified:
6 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), James Su, ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Omnibox.mojom: make input_string non-nullable. The bug in JavaScript encoder that prevented us from doing so has been fixed. BUG=None TEST=None Committed: https://crrev.com/18e90f62acf16c0c6347737c32f85525ff90b65d Cr-Commit-Position: refs/heads/master@{#292419}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/ui/webui/omnibox/omnibox.mojom	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yzshen1

yzshen@chromium.org changed reviewers: + sky@chromium.org

6 years, 3 months ago (2014-08-28 00:27:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/509173003/1

6 years, 3 months ago (2014-08-28 16:10:59 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 658af6cd02fa3f52c0b34cb67ddbb4d29ab1a7d5

6 years, 3 months ago (2014-08-28 18:29:32 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:00:46 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/18e90f62acf16c0c6347737c32f85525ff90b65d
Cr-Commit-Position: refs/heads/master@{#292419}

Expand Messages | Collapse Messages