Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: chrome/browser/ui/webui/omnibox/omnibox.mojom

Issue 509173003: Omnibox.mojom: make input_string non-nullable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The structures here roughly mirror those from autocomplete. 5 // The structures here roughly mirror those from autocomplete.
6 6
7 struct AutocompleteAdditionalInfo { 7 struct AutocompleteAdditionalInfo {
8 string key; 8 string key;
9 string value; 9 string value;
10 }; 10 };
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // Time delta since the request was started, in milliseconds. 42 // Time delta since the request was started, in milliseconds.
43 int32 time_since_omnibox_started_ms; 43 int32 time_since_omnibox_started_ms;
44 string host; 44 string host;
45 bool is_typed_host; 45 bool is_typed_host;
46 AutocompleteMatchMojo[] combined_results; 46 AutocompleteMatchMojo[] combined_results;
47 AutocompleteResultsForProviderMojo[] results_by_provider; 47 AutocompleteResultsForProviderMojo[] results_by_provider;
48 }; 48 };
49 49
50 [Client=OmniboxPage] 50 [Client=OmniboxPage]
51 interface OmniboxUIHandlerMojo { 51 interface OmniboxUIHandlerMojo {
52 // TODO(yzshen): Conceptually |input_string| could be non-nullable. However, 52 StartOmniboxQuery(string input_string,
53 // crbug.com/407258 (JavaScript encoder encodes empty string as null) prevents
54 // us from doing so. Change it into non-nullable once the bug is resolved.
55 StartOmniboxQuery(string? input_string,
56 int32 cursor_position, 53 int32 cursor_position,
57 bool prevent_inline_autocomplete, 54 bool prevent_inline_autocomplete,
58 bool prefer_keyword, 55 bool prefer_keyword,
59 int32 page_classification); 56 int32 page_classification);
60 }; 57 };
61 58
62 interface OmniboxPage { 59 interface OmniboxPage {
63 HandleNewAutocompleteResult(OmniboxResultMojo result); 60 HandleNewAutocompleteResult(OmniboxResultMojo result);
64 }; 61 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698