chrome/browser/ui/webui/omnibox/omnibox.mojom - Issue 509173003: Omnibox.mojom: make input_string non-nullable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/omnibox/omnibox.mojom

Issue 509173003: Omnibox.mojom: make input_string non-nullable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/omnibox/omnibox.mojom

diff --git a/chrome/browser/ui/webui/omnibox/omnibox.mojom b/chrome/browser/ui/webui/omnibox/omnibox.mojom

index 81736526472bae6b20092db05b745e74511cbb44..262ae76773c1ff1ba493ceee76277eb6f5335f55 100644

--- a/chrome/browser/ui/webui/omnibox/omnibox.mojom

+++ b/chrome/browser/ui/webui/omnibox/omnibox.mojom

@@ -49,10 +49,7 @@ struct OmniboxResultMojo {

[Client=OmniboxPage]

interface OmniboxUIHandlerMojo {

- // TODO(yzshen): Conceptually |input_string| could be non-nullable. However,

- // crbug.com/407258 (JavaScript encoder encodes empty string as null) prevents

- // us from doing so. Change it into non-nullable once the bug is resolved.

- StartOmniboxQuery(string? input_string,

+ StartOmniboxQuery(string input_string,

int32 cursor_position,

bool prevent_inline_autocomplete,

bool prefer_keyword,

« no previous file with comments | « no previous file | no next file » | no next file with comments »