Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 508873005: Reimplemented tree_for_master, which now uses gatekeeper config files to map master URLs to the tre… (Closed)

Created:
6 years, 3 months ago by Sergiy Byelozyorov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, eseidel, ghost stip (do not use), Jeffrey Yasskin
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Project:
infra
Visibility:
Public.

Description

Reimplemented tree_for_master, which now uses gatekeeper config files to map master URLs to the tree names. Also added tests to achieve 100% coverage for files which were not previously tested at all. Depends on https://codereview.chromium.org/514813003. BUG=406969 R=ojan@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/6290b51f8776f84d8b02f09702c1ade911e75a48

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Total comments: 8

Patch Set 9 : #

Patch Set 10 : Added python-mock dependency #

Patch Set 11 : Various changes to achieve 100% test coverage #

Patch Set 12 : Rebase #

Total comments: 22

Patch Set 13 : Review #

Patch Set 14 : Dummy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -58 lines) Patch
M bootstrap/deps.pyl View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -0 lines 0 comments Download
M infra/tools/builder_alerts/__main__.py View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +11 lines, -34 lines 0 comments Download
M infra/tools/builder_alerts/gatekeeper_extras.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +34 lines, -24 lines 0 comments Download
A infra/tools/builder_alerts/test/gatekeeper_extras_test.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +136 lines, -0 lines 0 comments Download

Messages

Total messages: 47 (15 generated)
Sergiy Byelozyorov
6 years, 3 months ago (2014-08-27 23:52:31 UTC) #1
ojan
Needs tests. Unfortunately, this code landed in a rush without tests, so we now need ...
6 years, 3 months ago (2014-08-28 03:34:15 UTC) #2
Sergiy Byelozyorov
PTAL https://codereview.chromium.org/508873005/diff/130001/infra/tools/builder_alerts/__main__.py File infra/tools/builder_alerts/__main__.py (right): https://codereview.chromium.org/508873005/diff/130001/infra/tools/builder_alerts/__main__.py#newcode51 infra/tools/builder_alerts/__main__.py:51: alert['tree_name'] = tree_name or buildbot.master_name_from_url(master_url) On 2014/08/28 03:34:15, ...
6 years, 3 months ago (2014-08-28 17:45:58 UTC) #3
ojan
lgtm
6 years, 3 months ago (2014-08-28 18:43:10 UTC) #4
Sergiy Byelozyorov
The CQ bit was checked by sergiyb@chromium.org
6 years, 3 months ago (2014-08-29 12:46:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/508873005/150001
6 years, 3 months ago (2014-08-29 12:46:47 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: infra_tester on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 12:48:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 12:49:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: infra_tester on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/builds/119)
6 years, 3 months ago (2014-08-29 12:49:39 UTC) #9
Sergiy Byelozyorov
The CQ bit was unchecked by sergiyb@chromium.org
6 years, 3 months ago (2014-08-29 12:50:06 UTC) #10
Sergiy Byelozyorov
Mock library is not available on the bots. Should I just add it to the ...
6 years, 3 months ago (2014-08-29 12:52:03 UTC) #11
Sergiy Byelozyorov
On 2014/08/29 12:52:03, Sergiy Byelozyorov wrote: > Mock library is not available on the bots. ...
6 years, 3 months ago (2014-08-29 13:57:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/508873005/170001
6 years, 3 months ago (2014-09-01 10:10:08 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: infra_tester on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-01 10:12:32 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: infra_tester on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/builds/126)
6 years, 3 months ago (2014-09-01 10:14:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/508873005/190001
6 years, 3 months ago (2014-09-02 16:08:32 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: infra_tester on tryserver.chromium.linux ...
6 years, 3 months ago (2014-09-02 16:10:24 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: infra_tester on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/builds/137)
6 years, 3 months ago (2014-09-02 16:12:04 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/508873005/210001
6 years, 3 months ago (2014-09-04 13:53:56 UTC) #24
Sergiy Byelozyorov
6 years, 3 months ago (2014-09-04 13:56:21 UTC) #27
Sergiy Byelozyorov
6 years, 3 months ago (2014-09-04 14:00:08 UTC) #29
tandrii(chromium)
lgtm with minor nitpicks. https://codereview.chromium.org/508873005/diff/230001/infra/tools/builder_alerts/__main__.py File infra/tools/builder_alerts/__main__.py (right): https://codereview.chromium.org/508873005/diff/230001/infra/tools/builder_alerts/__main__.py#newcode66 infra/tools/builder_alerts/__main__.py:66: logging.debug('Processing gatekeeper trees json: %s' ...
6 years, 3 months ago (2014-09-04 14:21:06 UTC) #33
agable
https://codereview.chromium.org/508873005/diff/230001/infra/tools/builder_alerts/gatekeeper_extras.py File infra/tools/builder_alerts/gatekeeper_extras.py (right): https://codereview.chromium.org/508873005/diff/230001/infra/tools/builder_alerts/gatekeeper_extras.py#newcode9 infra/tools/builder_alerts/gatekeeper_extras.py:9: import infra.tools.builder_alerts.buildbot Since you only use one thing, could ...
6 years, 3 months ago (2014-09-04 14:22:31 UTC) #34
agable
Also, rewrite the CL description so that the first line is short enough for Git ...
6 years, 3 months ago (2014-09-04 14:22:57 UTC) #35
ghost stip (do not use)
https://chromiumcodereview.appspot.com/508873005/diff/230001/bootstrap/deps.pyl File bootstrap/deps.pyl (right): https://chromiumcodereview.appspot.com/508873005/diff/230001/bootstrap/deps.pyl#newcode27 bootstrap/deps.pyl:27: 'gs': 'ba2b1d5f84448497e14e25922c5e3293f0a91c7e.tar.gz', I've copied mock to infra/third_party/mock Please switch ...
6 years, 3 months ago (2014-09-04 23:15:40 UTC) #37
Sergiy Byelozyorov
PTAL https://codereview.chromium.org/508873005/diff/230001/bootstrap/deps.pyl File bootstrap/deps.pyl (right): https://codereview.chromium.org/508873005/diff/230001/bootstrap/deps.pyl#newcode27 bootstrap/deps.pyl:27: 'gs': 'ba2b1d5f84448497e14e25922c5e3293f0a91c7e.tar.gz', On 2014/09/04 23:15:40, stip wrote: > ...
6 years, 3 months ago (2014-09-05 12:59:07 UTC) #39
Sergiy Byelozyorov
A note changes to mock.patch in the patchset 13: The test runner expect_tests, which we ...
6 years, 3 months ago (2014-09-05 13:06:24 UTC) #40
agable
On 2014/09/05 13:06:24, Sergiy Byelozyorov wrote: > A note changes to mock.patch in the patchset ...
6 years, 3 months ago (2014-09-05 13:12:09 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/508873005/270001
6 years, 3 months ago (2014-09-05 13:14:14 UTC) #43
commit-bot: I haz the power
This issue passed the CQ. To commit it, remove "COMMIT=false" from the description and try ...
6 years, 3 months ago (2014-09-05 13:16:13 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/508873005/290001
6 years, 3 months ago (2014-09-05 13:21:17 UTC) #46
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 13:23:22 UTC) #47
Message was sent while issue was closed.
Committed patchset #14 (id:290001) as 6290b51f8776f84d8b02f09702c1ade911e75a48

Powered by Google App Engine
This is Rietveld 408576698