Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 514813003: Added method for loading of the gatekeeper_trees.json config. (Closed)

Created:
6 years, 3 months ago by Sergiy Byelozyorov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, kjellander-cc_chromium.org, pgervais+watch_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Added method for loading of the gatekeeper_trees.json config. Used in https://codereview.chromium.org/508873005/. BUG=406969 R=ojan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291721

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Added a test to validate checked-in trees config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M scripts/slave/gatekeeper_ng_config.py View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M scripts/slave/unittests/gatekeeper_ng_test.py View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sergiy Byelozyorov
6 years, 3 months ago (2014-08-27 23:52:28 UTC) #1
ojan
ojan@chromium.org changed reviewers: + stip@chromium.org
6 years, 3 months ago (2014-08-28 03:35:52 UTC) #2
ojan
Stip is the best reviewer for this.
6 years, 3 months ago (2014-08-28 03:35:52 UTC) #3
ghost stip (do not use)
I guess the purpose of this CL is to verify the format? Unlike gatekeeper.json, gatekeeper_trees.json ...
6 years, 3 months ago (2014-08-28 19:17:17 UTC) #4
Sergiy Byelozyorov
On 2014/08/28 19:17:17, stip wrote: > I guess the purpose of this CL is to ...
6 years, 3 months ago (2014-08-29 09:18:41 UTC) #5
Sergiy Byelozyorov
The CQ bit was checked by sergiyb@chromium.org
6 years, 3 months ago (2014-08-29 09:19:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergiyb@chromium.org/514813003/70001
6 years, 3 months ago (2014-08-29 09:19:50 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 09:20:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as 291721

Powered by Google App Engine
This is Rietveld 408576698