Issue 508863002: [turbofan] Refactor code generation for calls.

Issue 508863002: [turbofan] Refactor code generation for calls. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Refactor code generation for calls. R=jarin@chromium.org TEST=cctest Committed: https://code.google.com/p/v8/source/detail?r=23429

Patch Set 1 #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+216 lines, -254 lines)			Patch
M	src/compiler/arm/code-generator-arm.cc	View	3 chunks	+46 lines, -52 lines	0 comments	Download
M	src/compiler/arm/instruction-codes-arm.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/compiler/arm/instruction-selector-arm.cc	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	src/compiler/arm64/code-generator-arm64.cc	View	3 chunks	+39 lines, -44 lines	0 comments	Download
M	src/compiler/arm64/instruction-codes-arm64.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/compiler/arm64/instruction-selector-arm64.cc	View	2 chunks	+4 lines, -4 lines	2 comments	Download
M	src/compiler/ia32/code-generator-ia32.cc	View	4 chunks	+47 lines, -52 lines	0 comments	Download
M	src/compiler/ia32/instruction-codes-ia32.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/compiler/instruction-codes.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/compiler/x64/code-generator-x64.cc	View	4 chunks	+53 lines, -59 lines	0 comments	Download
M	src/compiler/x64/instruction-codes-x64.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	2 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm https://codereview.chromium.org/508863002/diff/1/src/compiler/arm64/instruction-selector-arm64.cc File src/compiler/arm64/instruction-selector-arm64.cc (right): https://codereview.chromium.org/508863002/diff/1/src/compiler/arm64/instruction-selector-arm64.cc#newcode584 src/compiler/arm64/instruction-selector-arm64.cc:584: void InstructionSelector::VisitCall(Node* call, BasicBlock* continuation, Could not we ...

6 years, 3 months ago (2014-08-27 06:13:34 UTC) #3

Benedikt Meurer

https://codereview.chromium.org/508863002/diff/1/src/compiler/arm64/instruction-selector-arm64.cc File src/compiler/arm64/instruction-selector-arm64.cc (right): https://codereview.chromium.org/508863002/diff/1/src/compiler/arm64/instruction-selector-arm64.cc#newcode584 src/compiler/arm64/instruction-selector-arm64.cc:584: void InstructionSelector::VisitCall(Node* call, BasicBlock* continuation, Yep, that's the idea ...

6 years, 3 months ago (2014-08-27 06:24:47 UTC) #4

Benedikt Meurer

6 years, 3 months ago (2014-08-27 06:25:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as 23429 (presubmit successful).

Expand Messages | Collapse Messages