Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 508563003: Remove PageActionsController (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove PageActionsController Since we've consolidated most of the extension action execution code, this object is rather unneeded. Remove it. BUG=407665 Committed: https://crrev.com/509422321079c39ae5da129b10c4f7e125add280 Cr-Commit-Position: refs/heads/master@{#292177}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -274 lines) Patch
M chrome/browser/extensions/active_script_controller.h View 3 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/extensions/active_script_controller.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/location_bar_controller.h View 4 chunks +11 lines, -37 lines 0 comments Download
M chrome/browser/extensions/location_bar_controller.cc View 6 chunks +11 lines, -27 lines 0 comments Download
A + chrome/browser/extensions/location_bar_controller_unittest.cc View 5 chunks +9 lines, -4 lines 1 comment Download
D chrome/browser/extensions/page_action_controller.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/extensions/page_action_controller.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/extensions/page_action_controller_unittest.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Devlin
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-26 16:56:55 UTC) #1
Devlin
Patchset #1 (id:20001) has been deleted
6 years, 3 months ago (2014-08-26 16:57:00 UTC) #2
Devlin
rdevlin.cronin@chromium.org changed reviewers: + finnur@chromium.org
6 years, 3 months ago (2014-08-26 16:57:58 UTC) #3
Devlin
Woo! More code deletion!
6 years, 3 months ago (2014-08-26 16:57:58 UTC) #4
Finnur
LGTM https://codereview.chromium.org/508563003/diff/60001/chrome/browser/extensions/location_bar_controller_unittest.cc File chrome/browser/extensions/location_bar_controller_unittest.cc (right): https://codereview.chromium.org/508563003/diff/60001/chrome/browser/extensions/location_bar_controller_unittest.cc#newcode114 chrome/browser/extensions/location_bar_controller_unittest.cc:114: // this elsewhere? Not sure. Probably not.
6 years, 3 months ago (2014-08-27 16:00:15 UTC) #5
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 3 months ago (2014-08-27 16:03:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/508563003/60001
6 years, 3 months ago (2014-08-27 16:04:23 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-27 17:03:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001) as 81558f77497b6bc8d8fcd0ca9080dc2001bc974f
6 years, 3 months ago (2014-08-27 17:41:16 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:32 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/509422321079c39ae5da129b10c4f7e125add280
Cr-Commit-Position: refs/heads/master@{#292177}

Powered by Google App Engine
This is Rietveld 408576698