Remove PageActionsController

chrome/browser/extensions/location_bar_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/extensions/page_action_controller.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/extensions/test_extension_system.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/value_builder.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/users/scoped_test_user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #endif
 
 namespace extensions {
 namespace {
 
-class PageActionControllerTest : public ChromeRenderViewHostTestHarness {
+class LocationBarControllerUnitTest : public ChromeRenderViewHostTestHarness {
  protected:
   virtual void SetUp() OVERRIDE {
     ChromeRenderViewHostTestHarness::SetUp();
 #if defined OS_CHROMEOS
   test_user_manager_.reset(new chromeos::ScopedTestUserManager());
 #endif
     TabHelper::CreateForWebContents(web_contents());
-    // Create an ExtensionService so the PageActionController can find its
+    // Create an ExtensionService so the LocationBarController can find its
     // extensions.
     CommandLine command_line(CommandLine::NO_PROGRAM);
     Profile* profile =
         Profile::FromBrowserContext(web_contents()->GetBrowserContext());
     extension_service_ = static_cast<TestExtensionSystem*>(
         ExtensionSystem::Get(profile))->CreateExtensionService(
             &command_line, base::FilePath(), false);
   }
 
   virtual void TearDown() OVERRIDE {
@@ skipping 10 matching lines @@
   ExtensionService* extension_service_;
 
  private:
 #if defined OS_CHROMEOS
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
   scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
 #endif
 };
 
-TEST_F(PageActionControllerTest, NavigationClearsState) {
+// Test that navigating clears all state in a page action.
+TEST_F(LocationBarControllerUnitTest, NavigationClearsState) {
   scoped_refptr<const Extension> extension =
       ExtensionBuilder()
       .SetManifest(DictionaryBuilder()
                    .Set("name", "Extension with page action")
                    .Set("version", "1.0.0")
                    .Set("manifest_version", 2)
                    .Set("permissions", ListBuilder()
                         .Append("tabs"))
                    .Set("page_action", DictionaryBuilder()
                         .Set("default_title", "Hello")))
@@ skipping 19 matching lines @@
   EXPECT_EQ(extension->GetResourceURL("popup.html"),
             page_action.GetPopupUrl(tab_id()));
 
   // Should discard the settings, and go back to the defaults.
   NavigateAndCommit(GURL("http://www.yahoo.com"));
 
   EXPECT_EQ("Hello", page_action.GetTitle(tab_id()));
   EXPECT_EQ(GURL(), page_action.GetPopupUrl(tab_id()));
 };
 
+// TODO(devlin): We should really have more tests for this.
+// NavigationClearsState doesn't test at all that the LocationBarController
+// actually *returns* the proper PageActions in GetCurrentActions. Do we do
+// this elsewhere?

[Finnur, 2014/08/27 16:00:15]

Not sure. Probably not.

+
 }  // namespace
 }  // namespace extensions