chrome/browser/extensions/extension_action.cc - Issue 508563003: Remove PageActionsController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 508563003: Remove PageActionsController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_action.cc

diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc

index 78934f4c59e6877d0ecce22cf8a683a5b718ccab..ec6d3666c73a6ed3ea7cc0f137e87f92474b12ab 100644

--- a/chrome/browser/extensions/extension_action.cc

+++ b/chrome/browser/extensions/extension_action.cc

@@ -173,7 +173,7 @@ void ExtensionAction::ClearAllValuesForTab(int tab_id) {

is_visible_.erase(tab_id);

// TODO(jyasskin): Erase the element from declarative_show_count_

// when the tab's closed. There's a race between the

- // PageActionController and the ContentRulesRegistry on navigation,

+ // LocationBarController and the ContentRulesRegistry on navigation,

// which prevents me from cleaning everything up now.

}