Remove Finch kill switch for PSL matching

chrome/browser/password_manager/native_backend_gnome_x.cc

Index: chrome/browser/password_manager/native_backend_gnome_x.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.cc b/chrome/browser/password_manager/native_backend_gnome_x.cc
index 5d288b9f591bf9aa1c685f972e5a813df4f067b4..a311ecee86a68ef6cd216172e5fdddfd707a6293 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x.cc
@@ -194,9 +194,12 @@ void ConvertFormList(GList* found,
     }
   }
   if (lookup_form) {
+    const GURL signon_realm(lookup_form->signon_realm);
+    std::string registered_domain =
+        PSLMatchingHelper::GetRegistryControlledDomain(signon_realm);
     UMA_HISTOGRAM_ENUMERATION(
         "PasswordManager.PslDomainMatchTriggering",
-        helper.IsMatchingEnabled()
+        helper.ShouldPSLDomainMatchingApply(registered_domain)
             ? psl_domain_match_metric
             : PSLMatchingHelper::PSL_DOMAIN_MATCH_DISABLED,

[nyquist, 2014/08/27 18:15:14]

This else-clause looks a bit off to me. It's not disabled, but just not
triggered, no?

[vabr (Chromium), 2014/09/22 13:32:31]

There is no other disabling than not triggering, any more, I believe.
The current code in question is consistent with the LoginDatabase::GetLogins(),
which also reports PSL_DOMAIN_MATCH_DISABLED if ShouldPSLDomainMatchingApply
returns false.

Would you like me to rename the constant, or do you see deeper issues?

[nyquist, 2014/09/22 22:59:48]

No, I think it would only be a name change. Up to you though.

[vabr (Chromium), 2014/09/23 08:31:50]

I went with changing "disabled" to a more generic "not used". Please let me know
if you dislike that change.

         PSLMatchingHelper::PSL_DOMAIN_MATCH_COUNT);