Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 508143002: Remove Finch kill switch for PSL matching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
index 5de4972a4ada113ae85dc5d24083af4f1358e610..a93c6571dc3e1adf2b64776cae5052facb370a7d 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
@@ -534,7 +534,6 @@ class NativeBackendGnomeTest : public testing::Test {
// the credential update is done via UpdateLogin or AddLogin.
void CheckPSLUpdate(UpdateType update_type) {
password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
NativeBackendGnome backend(321);
backend.Init();
@@ -801,7 +800,6 @@ TEST_F(NativeBackendGnomeTest, PSLMatchingPositive) {
PasswordForm result;
const GURL kMobileURL("http://m.facebook.com/");
password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
EXPECT_TRUE(CheckCredentialAvailability(
form_facebook_, kMobileURL, PasswordForm::SCHEME_HTML, &result));
EXPECT_EQ(kMobileURL, result.origin);
@@ -812,7 +810,6 @@ TEST_F(NativeBackendGnomeTest, PSLMatchingPositive) {
// m-facebook.com.
TEST_F(NativeBackendGnomeTest, PSLMatchingNegativeDomainMismatch) {
password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
EXPECT_FALSE(CheckCredentialAvailability(
form_facebook_, GURL("http://m-facebook.com/"),
PasswordForm::SCHEME_HTML, NULL));
@@ -821,7 +818,6 @@ TEST_F(NativeBackendGnomeTest, PSLMatchingNegativeDomainMismatch) {
// Test PSL matching is off for domains excluded from it.
TEST_F(NativeBackendGnomeTest, PSLMatchingDisabledDomains) {
password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
EXPECT_FALSE(CheckCredentialAvailability(
form_google_, GURL("http://one.google.com/"),
PasswordForm::SCHEME_HTML, NULL));
@@ -830,7 +826,6 @@ TEST_F(NativeBackendGnomeTest, PSLMatchingDisabledDomains) {
// Make sure PSL matches aren't available for non-HTML forms.
TEST_F(NativeBackendGnomeTest, PSLMatchingDisabledForNonHTMLForms) {
password_manager::PSLMatchingHelper helper;
- ASSERT_TRUE(helper.IsMatchingEnabled());
CheckMatchingWithScheme(PasswordForm::SCHEME_BASIC);
CheckMatchingWithScheme(PasswordForm::SCHEME_DIGEST);

Powered by Google App Engine
This is Rietveld 408576698