Remove Finch kill switch for PSL matching

chrome/browser/password_manager/native_backend_gnome_x.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/native_backend_gnome_x.h"
 
 #include <dlfcn.h>
 #include <gnome-keyring.h>
 
 #include <map>
@@ skipping 176 matching lines @@
         form->password_value = UTF8ToUTF16(data->secret);
       } else {
         LOG(WARNING) << "Unable to access password from list element!";
       }
       forms->push_back(form.release());
     } else {
       LOG(WARNING) << "Could not initialize PasswordForm from attributes!";
     }
   }
   if (lookup_form) {
+    const GURL signon_realm(lookup_form->signon_realm);
+    std::string registered_domain =
+        PSLMatchingHelper::GetRegistryControlledDomain(signon_realm);
     UMA_HISTOGRAM_ENUMERATION(
         "PasswordManager.PslDomainMatchTriggering",
-        helper.IsMatchingEnabled()
+        helper.ShouldPSLDomainMatchingApply(registered_domain)
             ? psl_domain_match_metric
             : PSLMatchingHelper::PSL_DOMAIN_MATCH_DISABLED,

[nyquist, 2014/08/27 18:15:14]

This else-clause looks a bit off to me. It's not disabled, but just not
triggered, no?

[vabr (Chromium), 2014/09/22 13:32:31]

There is no other disabling than not triggering, any more, I believe.
The current code in question is consistent with the LoginDatabase::GetLogins(),
which also reports PSL_DOMAIN_MATCH_DISABLED if ShouldPSLDomainMatchingApply
returns false.

Would you like me to rename the constant, or do you see deeper issues?

[nyquist, 2014/09/22 22:59:48]

No, I think it would only be a name change. Up to you though.

[vabr (Chromium), 2014/09/23 08:31:50]

I went with changing "disabled" to a more generic "not used". Please let me know
if you dislike that change.

         PSLMatchingHelper::PSL_DOMAIN_MATCH_COUNT);
   }
 }
 
 // Schema is analagous to the fields in PasswordForm.
 // TODO(gcasto): Adding 'form_data' would be nice, but we would need to
 // serialize in a way that is guaranteed to not have any embedded NULLs. Pickle
 // doesn't make this guarantee, so we just don't serialize this field. Since
 // it's only used to crowd source data collection it doesn't matter that much
 // if it's not available on this platform.
@@ skipping 575 matching lines @@
   }
   return ok;
 }
 
 std::string NativeBackendGnome::GetProfileSpecificAppString() const {
   // Originally, the application string was always just "chrome" and used only
   // so that we had *something* to search for since GNOME Keyring won't search
   // for nothing. Now we use it to distinguish passwords for different profiles.
   return base::StringPrintf("%s-%d", kGnomeKeyringAppString, profile_id_);
 }