device/serial/serial_connection_factory.cc - Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/serial/serial_connection_factory.cc

Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Regenerate Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/serial/serial_connection_factory.cc

diff --git a/device/serial/serial_connection_factory.cc b/device/serial/serial_connection_factory.cc

index 386286318305d49c53011a15739ccf7cbfadd4af..3e309b46ca4fdf908f9b19f57bed4c4f02f8441b 100644

--- a/device/serial/serial_connection_factory.cc

+++ b/device/serial/serial_connection_factory.cc

@@ -114,7 +114,7 @@ void SerialConnectionFactory::ConnectTask::Connect() {

}

void SerialConnectionFactory::ConnectTask::OnConnected(bool success) {

- DCHECK(io_handler_);

+ DCHECK(io_handler_.get());

if (!success)

return;

if (!options_)

« no previous file with comments | « device/serial/data_source_sender.cc ('k') | device/serial/serial_connection_unittest.cc » ('j') | no next file with comments »