Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: device/serial/serial_connection_factory.cc

Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Regenerate Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/data_source_sender.cc ('k') | device/serial/serial_connection_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/serial/serial_connection_factory.h" 5 #include "device/serial/serial_connection_factory.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "device/serial/serial_connection.h" 9 #include "device/serial/serial_connection.h"
10 #include "device/serial/serial_io_handler.h" 10 #include "device/serial/serial_io_handler.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 } 107 }
108 108
109 void SerialConnectionFactory::ConnectTask::Connect() { 109 void SerialConnectionFactory::ConnectTask::Connect() {
110 io_handler_ = factory_->io_handler_factory_.Run(); 110 io_handler_ = factory_->io_handler_factory_.Run();
111 io_handler_->Open( 111 io_handler_->Open(
112 path_, 112 path_,
113 base::Bind(&SerialConnectionFactory::ConnectTask::OnConnected, this)); 113 base::Bind(&SerialConnectionFactory::ConnectTask::OnConnected, this));
114 } 114 }
115 115
116 void SerialConnectionFactory::ConnectTask::OnConnected(bool success) { 116 void SerialConnectionFactory::ConnectTask::OnConnected(bool success) {
117 DCHECK(io_handler_); 117 DCHECK(io_handler_.get());
118 if (!success) 118 if (!success)
119 return; 119 return;
120 if (!options_) 120 if (!options_)
121 options_ = serial::ConnectionOptions::New(); 121 options_ = serial::ConnectionOptions::New();
122 FillDefaultConnectionOptions(options_.get()); 122 FillDefaultConnectionOptions(options_.get());
123 if (!io_handler_->ConfigurePort(*options_)) 123 if (!io_handler_->ConfigurePort(*options_))
124 return; 124 return;
125 mojo::BindToRequest( 125 mojo::BindToRequest(
126 new SerialConnection(io_handler_, sink_.Pass(), source_.Pass()), 126 new SerialConnection(io_handler_, sink_.Pass(), source_.Pass()),
127 &connection_request_); 127 &connection_request_);
128 } 128 }
129 129
130 } // namespace device 130 } // namespace device
OLDNEW
« no previous file with comments | « device/serial/data_source_sender.cc ('k') | device/serial/serial_connection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698