Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: device/serial/data_source_sender.cc

Issue 507053002: Remove implicit conversions from scoped_refptr to T* in device/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Regenerate Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/data_sink_unittest.cc ('k') | device/serial/serial_connection_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/data_source_sender.cc
diff --git a/device/serial/data_source_sender.cc b/device/serial/data_source_sender.cc
index 876a5e5557fffc93b79bbba928ed2aef2a115d34..c240303973c4dee55b400205544088446e11d29e 100644
--- a/device/serial/data_source_sender.cc
+++ b/device/serial/data_source_sender.cc
@@ -214,7 +214,7 @@ DataSourceSender::PendingSend::Buffer::Buffer(
}
DataSourceSender::PendingSend::Buffer::~Buffer() {
- if (sender_)
+ if (sender_.get())
pending_send_->Done(0);
}
@@ -227,7 +227,7 @@ uint32_t DataSourceSender::PendingSend::Buffer::GetSize() {
}
void DataSourceSender::PendingSend::Buffer::Done(uint32_t bytes_written) {
- DCHECK(sender_);
+ DCHECK(sender_.get());
pending_send_->Done(bytes_written);
sender_ = NULL;
pending_send_ = NULL;
@@ -238,7 +238,7 @@ void DataSourceSender::PendingSend::Buffer::Done(uint32_t bytes_written) {
void DataSourceSender::PendingSend::Buffer::DoneWithError(
uint32_t bytes_written,
int32_t error) {
- DCHECK(sender_);
+ DCHECK(sender_.get());
pending_send_->DoneWithError(bytes_written, error);
sender_ = NULL;
pending_send_ = NULL;
« no previous file with comments | « device/serial/data_sink_unittest.cc ('k') | device/serial/serial_connection_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698