Issue 506553004: Make the compositing assert disabler for paint invalidation more targeted.

Issue 506553004: Make the compositing assert disabler for paint invalidation more targeted. (Closed)

Created:
6 years, 4 months ago by chrishtr

Modified:
6 years, 3 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make the compositing assert disabler for paint invalidation more targeted. BUG=360286 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180997

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Fix. #

Patch Set 4 : Merged. #

Patch Set 5 : Fix. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -5 lines)			Patch
M	Source/core/editing/Caret.cpp	View	1 2 3	3 chunks	+6 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameView.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLCanvasElement.cpp	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderImage.cpp	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayerScrollableArea.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/rendering/RenderView.cpp	View	1 2 3	3 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/web/WebPluginContainerImpl.cpp	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

chrishtr

chrishtr@chromium.org changed reviewers: + abarth@chromium.org

6 years, 3 months ago (2014-08-27 15:52:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/506553004/60001

6 years, 3 months ago (2014-08-27 18:46:59 UTC) #5

commit-bot: I haz the power

Committed patchset #4 (id:60001) as 180997

6 years, 3 months ago (2014-08-27 19:23:39 UTC) #6

mlamouri (slow - plz ping)

6 years, 3 months ago (2014-08-28 10:43:25 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #4) has been created in
https://codereview.chromium.org/516603003/ by mlamouri@chromium.org.

The reason for reverting is: This seems to be asserting in many PPAPI tests. For
example:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@To....

Expand Messages | Collapse Messages