Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 506553004: Make the compositing assert disabler for paint invalidation more targeted. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderView.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 467
468 return compositedLayerMappingChanged; 468 return compositedLayerMappingChanged;
469 } 469 }
470 470
471 void RenderLayerCompositor::paintInvalidationOnCompositingChange(RenderLayer* la yer) 471 void RenderLayerCompositor::paintInvalidationOnCompositingChange(RenderLayer* la yer)
472 { 472 {
473 // If the renderer is not attached yet, no need to issue paint invalidations . 473 // If the renderer is not attached yet, no need to issue paint invalidations .
474 if (layer->renderer() != &m_renderView && !layer->renderer()->parent()) 474 if (layer->renderer() != &m_renderView && !layer->renderer()->parent())
475 return; 475 return;
476 476
477 // For querying RenderLayer::compositingState()
478 // Eager invalidation here is correct, since we are invalidating with respec t to the previous frame's
479 // compositing state when changing the compositing backing of the layer.
480 DisableCompositingQueryAsserts disabler;
481
477 layer->paintInvalidator().paintInvalidationIncludingNonCompositingDescendant s(); 482 layer->paintInvalidator().paintInvalidationIncludingNonCompositingDescendant s();
478 } 483 }
479 484
480 void RenderLayerCompositor::frameViewDidChangeLocation(const IntPoint& contentsO ffset) 485 void RenderLayerCompositor::frameViewDidChangeLocation(const IntPoint& contentsO ffset)
481 { 486 {
482 if (m_overflowControlsHostLayer) 487 if (m_overflowControlsHostLayer)
483 m_overflowControlsHostLayer->setPosition(contentsOffset); 488 m_overflowControlsHostLayer->setPosition(contentsOffset);
484 } 489 }
485 490
486 void RenderLayerCompositor::frameViewDidChangeSize() 491 void RenderLayerCompositor::frameViewDidChangeSize()
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
1164 } else if (graphicsLayer == m_scrollLayer.get()) { 1169 } else if (graphicsLayer == m_scrollLayer.get()) {
1165 name = "LocalFrame Scrolling Layer"; 1170 name = "LocalFrame Scrolling Layer";
1166 } else { 1171 } else {
1167 ASSERT_NOT_REACHED(); 1172 ASSERT_NOT_REACHED();
1168 } 1173 }
1169 1174
1170 return name; 1175 return name;
1171 } 1176 }
1172 1177
1173 } // namespace blink 1178 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderView.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698