net : Declaring the weak_ptr_factory in proper order.

Declaring the weak_ptr_factory in proper order.

Cleaning up weak_ptr_factory destruction order in "src/net" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818
Committed: https://crrev.com/cd7b446148ba6ef5874000c3679d6431b6d5588b
Cr-Commit-Position: refs/heads/master@{#292344}

[ARUNKK, 2014-08-25 09:14:34]

PTAL

[ARUNKK, 2014-08-26 05:38:56]

kulkarni.a@samsung.com changed reviewers:
- kphanee@chromium.org, l.gombos@samsung.com, sivagunturi@chromium.org,
sohanjg@chromium.org, vivekg@chromium.org

[ARUNKK, 2014-08-26 05:45:51]

kulkarni.a@samsung.com changed reviewers:
+ dmichael@chromium.org

[ARUNKK, 2014-08-26 05:45:51]

PTAL.

[ARUNKK, 2014-08-26 05:51:30]

kulkarni.a@samsung.com changed reviewers:
+ rdsmith@chromium.org

[ARUNKK, 2014-08-26 05:51:30]

rdsmith@chromium.org: Please review changes in 
"src/net"  module.

[Randy Smith (Not in Mondays), 2014-08-26 16:43:03]

https://codereview.chromium.org/506523002/diff/60001/net/http/disk_cache_base...
File net/http/disk_cache_based_quic_server_info.h (right):

https://codereview.chromium.org/506523002/diff/60001/net/http/disk_cache_base...
net/http/disk_cache_based_quic_server_info.h:102: CompletionCallback
io_callback_;
I dislike making this exception to the general rule that the factory should be
the last thing.  Would it work to initialize the io_callback_ in the body of the
constructor, instead?  (Applies throughout review.)

[dmichael (off chromium), 2014-08-26 22:02:26]

https://codereview.chromium.org/506523002/diff/60001/net/http/disk_cache_base...
File net/http/disk_cache_based_quic_server_info.h (right):

https://codereview.chromium.org/506523002/diff/60001/net/http/disk_cache_base...
net/http/disk_cache_based_quic_server_info.h:102: CompletionCallback
io_callback_;
On 2014/08/26 16:43:03, rdsmith wrote:
> I dislike making this exception to the general rule that the factory should be
> the last thing.  Would it work to initialize the io_callback_ in the body of
the
> constructor, instead?  (Applies throughout review.)
> 
+1, that's how I've been resolving these. Doing this may not be safe and the
clang plugin will eventually complain about it.

[ARUNKK, 2014-08-27 14:08:09]

On 2014/08/26 22:02:26, dmichael wrote:
>
https://codereview.chromium.org/506523002/diff/60001/net/http/disk_cache_base...
> File net/http/disk_cache_based_quic_server_info.h (right):
> 
>
https://codereview.chromium.org/506523002/diff/60001/net/http/disk_cache_base...
> net/http/disk_cache_based_quic_server_info.h:102: CompletionCallback
> io_callback_;
> On 2014/08/26 16:43:03, rdsmith wrote:
> > I dislike making this exception to the general rule that the factory should
be
> > the last thing.  Would it work to initialize the io_callback_ in the body of
> the
> > constructor, instead?  (Applies throughout review.)
> > 
> +1, that's how I've been resolving these. Doing this may not be safe and the
> clang plugin will eventually complain about it.

Thanks for review .
changes are incorporated ,
PTAL.

[Randy Smith (Not in Mondays), 2014-08-27 14:25:15]

LGTM with nit (vertical whitespace--it's up to you what you do with the
COMPILE_ASSERT).

https://codereview.chromium.org/506523002/diff/80001/net/http/http_cache_tran...
File net/http/http_cache_transaction.cc (right):

https://codereview.chromium.org/506523002/diff/80001/net/http/http_cache_tran...
net/http/http_cache_transaction.cc:336: 
nit: I don't think there's any need for vertical whitespace here.

https://codereview.chromium.org/506523002/diff/80001/net/http/http_cache_tran...
net/http/http_cache_transaction.cc:341: Invalid_number_of_validation_headers);
I have a slight preference for high level asserts being the first thing in a
function, but it's a preference--up to you.

[ARUNKK, 2014-08-28 05:19:51]

On 2014/08/27 14:25:15, rdsmith wrote:
> LGTM with nit (vertical whitespace--it's up to you what you do with the
> COMPILE_ASSERT).
> 
>
https://codereview.chromium.org/506523002/diff/80001/net/http/http_cache_tran...
> File net/http/http_cache_transaction.cc (right):
> 
>
https://codereview.chromium.org/506523002/diff/80001/net/http/http_cache_tran...
> net/http/http_cache_transaction.cc:336: 
> nit: I don't think there's any need for vertical whitespace here.
> 
>
https://codereview.chromium.org/506523002/diff/80001/net/http/http_cache_tran...
> net/http/http_cache_transaction.cc:341: Invalid_number_of_validation_headers);
> I have a slight preference for high level asserts being the first thing in a
> function, but it's a preference--up to you.

Thanks for review,I have incorporated the nit  from review .

[ARUNKK, 2014-08-28 05:19:59]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-08-28 05:20:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/506523002/100001

[ARUNKK, 2014-08-28 05:41:01]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-08-28 05:41:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/506523002/120001

[ARUNKK, 2014-08-28 05:55:36]

The CQ bit was checked by kulkarni.a@samsung.com

[commit-bot: I haz the power, 2014-08-28 05:56:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/506523002/140001

[commit-bot: I haz the power, 2014-08-28 06:57:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 07:41:49]

Committed patchset #8 (id:140001) as 00ca4a09c586988ad935827de99709ee89ab1cc8

[commit-bot: I haz the power, 2014-09-10 02:58:20]

Patchset 8 (id:??) landed as
https://crrev.com/cd7b446148ba6ef5874000c3679d6431b6d5588b
Cr-Commit-Position: refs/heads/master@{#292344}