Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1952)

Unified Diff: net/http/disk_cache_based_quic_server_info.cc

Issue 506523002: net : Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/disk_cache_based_quic_server_info.h ('k') | net/http/http_auth_handler_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/disk_cache_based_quic_server_info.cc
diff --git a/net/http/disk_cache_based_quic_server_info.cc b/net/http/disk_cache_based_quic_server_info.cc
index 4cf036de3ba8f70e779b82f714a8486d82ee3671..7b400ac7dd1e2280d69111a86f479335155af375 100644
--- a/net/http/disk_cache_based_quic_server_info.cc
+++ b/net/http/disk_cache_based_quic_server_info.cc
@@ -47,19 +47,19 @@ DiskCacheBasedQuicServerInfo::DiskCacheBasedQuicServerInfo(
const QuicServerId& server_id,
HttpCache* http_cache)
: QuicServerInfo(server_id),
- weak_factory_(this),
data_shim_(new CacheOperationDataShim()),
- io_callback_(
- base::Bind(&DiskCacheBasedQuicServerInfo::OnIOComplete,
- weak_factory_.GetWeakPtr(),
- base::Owned(data_shim_))), // Ownership assigned.
state_(GET_BACKEND),
ready_(false),
found_entry_(false),
server_id_(server_id),
http_cache_(http_cache),
backend_(NULL),
- entry_(NULL) {
+ entry_(NULL),
+ weak_factory_(this) {
+ io_callback_ =
+ base::Bind(&DiskCacheBasedQuicServerInfo::OnIOComplete,
+ weak_factory_.GetWeakPtr(),
+ base::Owned(data_shim_)); // Ownership assigned.
}
void DiskCacheBasedQuicServerInfo::Start() {
« no previous file with comments | « net/http/disk_cache_based_quic_server_info.h ('k') | net/http/http_auth_handler_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698