Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: net/test/embedded_test_server/embedded_test_server.h

Issue 506523002: net : Declaring the weak_ptr_factory in proper order. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | net/test/spawned_test_server/spawner_communicator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/embedded_test_server/embedded_test_server.h
diff --git a/net/test/embedded_test_server/embedded_test_server.h b/net/test/embedded_test_server/embedded_test_server.h
index 1232388a6ca62c8532f811a2ec7753fcb96dc9b8..a490f25775d48cf3c82adef580c8d8ec86c67ca9 100644
--- a/net/test/embedded_test_server/embedded_test_server.h
+++ b/net/test/embedded_test_server/embedded_test_server.h
@@ -186,12 +186,12 @@ class EmbeddedTestServer : public StreamListenSocket::Delegate {
// Vector of registered request handlers.
std::vector<HandleRequestCallback> request_handlers_;
+ base::ThreadChecker thread_checker_;
+
// Note: This should remain the last member so it'll be destroyed and
// invalidate its weak pointers before any other members are destroyed.
base::WeakPtrFactory<EmbeddedTestServer> weak_factory_;
- base::ThreadChecker thread_checker_;
-
DISALLOW_COPY_AND_ASSIGN(EmbeddedTestServer);
};
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | net/test/spawned_test_server/spawner_communicator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698