Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/ui/location_bar/location_bar.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/location_bar/location_bar.cc
diff --git a/chrome/browser/ui/location_bar/location_bar.cc b/chrome/browser/ui/location_bar/location_bar.cc
index 0e1edd993d90fba5f6b3e8cfd9cbea0f01a8aa47..aad03b260efe2eb632731eef4f9e33e3134f1c2e 100644
--- a/chrome/browser/ui/location_bar/location_bar.cc
+++ b/chrome/browser/ui/location_bar/location_bar.cc
@@ -23,7 +23,7 @@ bool LocationBar::IsBookmarkStarHiddenByExtension() const {
extensions::ExtensionRegistry::Get(profile_)->enabled_extensions();
for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
i != extension_set.end(); ++i) {
- if (extensions::UIOverrides::RemovesBookmarkButton(*i) &&
+ if (extensions::UIOverrides::RemovesBookmarkButton(i->get()) &&
((*i)->permissions_data()->HasAPIPermission(
msw 2014/08/26 23:39:24 q: did you intend to fix this (*i) too?
dcheng 2014/08/26 23:45:09 Technically, I don't think this one needs to be re
msw 2014/08/27 00:02:39 Acknowledged.
extensions::APIPermission::kBookmarkManagerPrivate) ||
extensions::FeatureSwitch::enable_override_bookmarks_ui()

Powered by Google App Engine
This is Rietveld 408576698