Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils.cc

Issue 505913002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_utils.cc
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils.cc b/chrome/browser/ui/bookmarks/bookmark_utils.cc
index 5cab1b4d6cfab0078d2f76ab0d2a3e8b893f0514..be1f781dda6c890013a7dd6684c661c6af2d619a 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils.cc
+++ b/chrome/browser/ui/bookmarks/bookmark_utils.cc
@@ -172,10 +172,11 @@ BookmarkShortcutDisposition GetBookmarkShortcutDisposition(Profile* profile) {
i != extension_set.end();
++i) {
// Use the overridden disposition if any extension wants it.
- if (command_service->OverridesBookmarkShortcut(*i))
+ if (command_service->OverridesBookmarkShortcut(i->get()))
return BOOKMARK_SHORTCUT_DISPOSITION_OVERRIDDEN;
- if (!removed && extensions::CommandService::RemovesBookmarkShortcut(*i))
+ if (!removed &&
+ extensions::CommandService::RemovesBookmarkShortcut(i->get()))
msw 2014/08/26 23:39:24 optional nit: add curly braces.
dcheng 2014/08/26 23:45:09 Done.
removed = true;
}
@@ -355,7 +356,7 @@ bool ShouldRemoveBookmarkOpenPagesUI(Profile* profile) {
for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
i != extension_set.end();
++i) {
- if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(*i))
+ if (extensions::CommandService::RemovesBookmarkOpenPagesShortcut(i->get()))
return true;
}

Powered by Google App Engine
This is Rietveld 408576698