Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 505713002: [turbofan] Add backend support for signed loads. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev, Michael Starzinger
Project:
v8
Visibility:
Public.

Description

[turbofan] Add backend support for signed loads. Also rename the arch opcodes to match their native counterparts. TEST=compiler-unittests,cctest R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23345

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : Fix x64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+683 lines, -254 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +10 lines, -8 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 6 chunks +19 lines, -23 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +16 lines, -10 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +12 lines, -10 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 5 chunks +11 lines, -16 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +38 lines, -38 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +8 lines, -11 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 4 chunks +10 lines, -11 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/machine-type.h View 2 chunks +10 lines, -3 lines 0 comments Download
M src/compiler/machine-type.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 2 chunks +66 lines, -68 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 2 chunks +10 lines, -16 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 4 chunks +19 lines, -14 lines 0 comments Download
M test/compiler-unittests/arm/instruction-selector-arm-unittest.cc View 1 chunk +134 lines, -0 lines 0 comments Download
M test/compiler-unittests/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M test/compiler-unittests/ia32/instruction-selector-ia32-unittest.cc View 1 chunk +132 lines, -0 lines 0 comments Download
M test/compiler-unittests/x64/instruction-selector-x64-unittest.cc View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
PTAL
6 years, 4 months ago (2014-08-25 08:51:29 UTC) #1
Benedikt Meurer
Michi: FYI
6 years, 4 months ago (2014-08-25 09:35:59 UTC) #2
Jarin
lgtm lgtm
6 years, 4 months ago (2014-08-25 10:34:25 UTC) #3
Jarin
lgtm
6 years, 4 months ago (2014-08-25 10:34:26 UTC) #4
Benedikt Meurer
6 years, 4 months ago (2014-08-25 10:35:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as 23345 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698