Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 504893003: Attempt to let libvpx's SSE files build with clang-cl. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
5 years, 6 months ago
CC:
chromium-reviews, wwcv, jzern, fgalligan1
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Project:
chromium
Visibility:
Public.

Description

Attempt to let libvpx's SSE files build with clang-cl. cl.exe can use intrinsics even if the arch targeted by the compiler doesn't support the SSE level needed by the intrinsic. clang (and gcc) can't do this, because it converts intrinsics into general LLVM operations, and the LLVM bitcode is then translated back into assembly later on, based on the target arch. So explicitly enable SSSE3 and SSE4 when using clang-cl, so that the intrinsics compile. (It's unfortunate that clang-cl deviates fairly heavily from cl in this regard. But this is very difficult to change, and it's the only larger deviation so far.) Depends on https://codereview.chromium.org/508433003/ Similar to https://codereview.chromium.org/475273002/ and https://codereview.chromium.org/493883002/ BUG=82385 r291625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M generate_gypi.sh View 1 chunk +10 lines, -0 lines 0 comments Download
M libvpx_srcs_x86_64_intrinsics.gypi View 2 chunks +18 lines, -0 lines 0 comments Download
M libvpx_srcs_x86_intrinsics.gypi View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Nico
thakis@chromium.org changed reviewers: + fgalligan@chromium.org, johannkoenig@chromium.org
6 years, 4 months ago (2014-08-25 23:04:58 UTC) #1
Nico
6 years, 4 months ago (2014-08-25 23:04:58 UTC) #2
Nico
thakis@chromium.org changed reviewers: + tomfinegan@chromium.org
6 years, 4 months ago (2014-08-26 00:27:36 UTC) #3
Nico
Tom, since you approved the prerequisite CL, do you want to stamp this one too?
6 years, 4 months ago (2014-08-26 00:27:36 UTC) #4
Tom Finegan
On 2014/08/26 00:27:36, Nico (hiding) wrote: > Tom, since you approved the prerequisite CL, do ...
6 years, 4 months ago (2014-08-26 00:30:33 UTC) #5
Johann
Is this ready to merge?
6 years, 3 months ago (2014-09-02 17:08:19 UTC) #6
Nico
On 2014/09/02 17:08:19, Johann wrote: > Is this ready to merge? I landed this r291625 ...
6 years, 3 months ago (2014-09-02 17:12:49 UTC) #7
Johann
On 2014/09/02 17:12:49, Nico (hiding) wrote: > On 2014/09/02 17:08:19, Johann wrote: > > Is ...
6 years, 3 months ago (2014-09-02 17:16:19 UTC) #8
Nico
Huh, looks like there are two libvpx repos: https://chromium.googlesource.com/webm/libvpx/ https://chromium.googlesource.com/chromium/deps/libvpx/ My CL made it to ...
5 years, 6 months ago (2015-06-05 00:53:47 UTC) #9
Tom Finegan
On 2015/06/05 00:53:47, Nico wrote: > Huh, looks like there are two libvpx repos: > ...
5 years, 6 months ago (2015-06-05 01:24:34 UTC) #10
chromium-reviews
The next step is to update src/DEPS with the hash from your change. I think ...
5 years, 6 months ago (2015-06-05 01:54:16 UTC) #11
chromium-reviews
https://codereview.chromium.org/1159113005 On Jun 4, 2015 9:54 PM, "Johann Koenig" <johannkoenig@google.com> wrote: > The next step ...
5 years, 6 months ago (2015-06-05 01:55:43 UTC) #12
Nico
5 years, 6 months ago (2015-06-05 01:56:48 UTC) #13
Message was sent while issue was closed.
Thanks, I have that in the cq already.
On Jun 4, 2015 6:54 PM, "Johann Koenig" <johannkoenig@google.com> wrote:

> The next step is to update src/DEPS with the hash from your change. I
> think I have a recent change in my dashboard you can use as a template
> On Jun 4, 2015 9:24 PM, <tomfinegan@chromium.org> wrote:
>
>> On 2015/06/05 00:53:47, Nico wrote:
>>
>>> Huh, looks like there are two libvpx repos:
>>>
>>
>>  https://chromium.googlesource.com/webm/libvpx/
>>> https://chromium.googlesource.com/chromium/deps/libvpx/
>>>
>>
>>  My CL made it to the latter. Is that the right one?
>>>
>>
>> For Chromium, yes. The webm/libvpx repo is the upstream repo tracked by
>> Chromium
>> in deps (with Chromium config stuff like gyp/gn files and update scripts).
>>
>> https://codereview.chromium.org/504893003/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698