Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: libvpx_srcs_x86_64_intrinsics.gypi

Issue 504893003: Attempt to let libvpx's SSE files build with clang-cl. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « generate_gypi.sh ('k') | libvpx_srcs_x86_intrinsics.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libvpx_srcs_x86_64_intrinsics.gypi
diff --git a/libvpx_srcs_x86_64_intrinsics.gypi b/libvpx_srcs_x86_64_intrinsics.gypi
index 9a2c2a112aa12950b519c34d2d3aa9c47697bae1..fb96a438a216d866ac22089f7a24007e136b2710 100644
--- a/libvpx_srcs_x86_64_intrinsics.gypi
+++ b/libvpx_srcs_x86_64_intrinsics.gypi
@@ -59,6 +59,15 @@
],
'cflags': [ '-mssse3', ],
'xcode_settings': { 'OTHER_CFLAGS': [ '-mssse3' ] },
+ 'conditions': [
+ ['OS=="win" and clang==1', {
+ # cl.exe's /arch flag doesn't have a setting for SSSE3/4, and cl.exe
+ # doesn't need it for intrinsics. clang-cl does need it, though.
+ 'msvs_settings': {
+ 'VCCLCompilerTool': { 'AdditionalOptions': [ '-mssse3' ] },
+ },
+ }],
+ ],
},
{
'target_name': 'libvpx_intrinsics_sse4_1',
@@ -72,6 +81,15 @@
],
'cflags': [ '-msse4.1', ],
'xcode_settings': { 'OTHER_CFLAGS': [ '-msse4.1' ] },
+ 'conditions': [
+ ['OS=="win" and clang==1', {
+ # cl.exe's /arch flag doesn't have a setting for SSSE3/4, and cl.exe
+ # doesn't need it for intrinsics. clang-cl does need it, though.
+ 'msvs_settings': {
+ 'VCCLCompilerTool': { 'AdditionalOptions': [ '-msse4.1' ] },
+ },
+ }],
+ ],
},
],
}
« no previous file with comments | « generate_gypi.sh ('k') | libvpx_srcs_x86_intrinsics.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698