Issue 504793002: Teach chromium_roll script to roll v8 git hashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 504793002: Teach chromium_roll script to roll v8 git hashes. (Closed)

Created:
6 years, 4 months ago by Michael Achenbach

Modified:
6 years, 4 months ago

Reviewers:
Ryan Tseng, Jarin, hinoka

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Teach chromium_roll script to roll v8 git hashes. TEST=script_test.py R=hinoka@google.com Committed: https://code.google.com/p/v8/source/detail?r=23379

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	tools/push-to-trunk/chromium_roll.py	View		1 chunk	+3 lines, -5 lines	1 comment	Download
	M	tools/push-to-trunk/test_scripts.py	View		3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Tseng

lgtm where's roll-dep located? https://codereview.chromium.org/504793002/diff/1/tools/push-to-trunk/chromium_roll.py File tools/push-to-trunk/chromium_roll.py (right): https://codereview.chromium.org/504793002/diff/1/tools/push-to-trunk/chromium_roll.py#newcode88 tools/push-to-trunk/chromium_roll.py:88: "roll-dep", "v8 %s" % self["trunk_revision"]) ...

6 years, 4 months ago (2014-08-25 13:51:56 UTC) #2

Michael Achenbach

On 2014/08/25 13:51:56, Ryan T. (EMEA time) wrote: > lgtm > > where's roll-dep located? ...

6 years, 4 months ago (2014-08-25 15:12:23 UTC) #3

Michael Achenbach

6 years, 4 months ago (2014-08-25 20:04:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 23379 (presubmit successful).

Expand Messages | Collapse Messages