Teach chromium_roll script to roll v8 git hashes.

tools/push-to-trunk/chromium_roll.py

Index: tools/push-to-trunk/chromium_roll.py
diff --git a/tools/push-to-trunk/chromium_roll.py b/tools/push-to-trunk/chromium_roll.py
index 0138ff8e72f8bb898ffafd0ab46bb4e1b3d360c2..c5687d1bc29caeff9865e5fa5fcea38995e12a9d 100755
--- a/tools/push-to-trunk/chromium_roll.py
+++ b/tools/push-to-trunk/chromium_roll.py
@@ -84,11 +84,9 @@ class UploadCL(Step):
     os.chdir(self["chrome_path"])
 
     # Patch DEPS file.
-    deps = FileToText(self.Config(DEPS_FILE))
-    deps = re.sub("(?<=\"v8_revision\": \")([0-9]+)(?=\")",
-                  self["trunk_revision"],
-                  deps)
-    TextToFile(deps, self.Config(DEPS_FILE))
+    if self._side_effect_handler.Command(
+        "roll-dep", "v8 %s" % self["trunk_revision"]) is None:

[Ryan Tseng, 2014/08/25 13:51:55]

nit: if foo() is None: -> if not foo(): to match chromium style

edit: okay scratch that, I see the Command() implementation >_<

+      self.Die("Failed to create deps for %s" % self["trunk_revision"])
 
     if self._options.reviewer and not self._options.manual:
       print "Using account %s for review." % self._options.reviewer