OLD | NEW |
---|---|
1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
2 # Copyright 2014 the V8 project authors. All rights reserved. | 2 # Copyright 2014 the V8 project authors. All rights reserved. |
3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be |
4 # found in the LICENSE file. | 4 # found in the LICENSE file. |
5 | 5 |
6 import argparse | 6 import argparse |
7 import os | 7 import os |
8 import sys | 8 import sys |
9 | 9 |
10 from common_includes import * | 10 from common_includes import * |
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
77 | 77 |
78 | 78 |
79 class UploadCL(Step): | 79 class UploadCL(Step): |
80 MESSAGE = "Create and upload CL." | 80 MESSAGE = "Create and upload CL." |
81 REQUIRES = "chrome_path" | 81 REQUIRES = "chrome_path" |
82 | 82 |
83 def RunStep(self): | 83 def RunStep(self): |
84 os.chdir(self["chrome_path"]) | 84 os.chdir(self["chrome_path"]) |
85 | 85 |
86 # Patch DEPS file. | 86 # Patch DEPS file. |
87 deps = FileToText(self.Config(DEPS_FILE)) | 87 if self._side_effect_handler.Command( |
88 deps = re.sub("(?<=\"v8_revision\": \")([0-9]+)(?=\")", | 88 "roll-dep", "v8 %s" % self["trunk_revision"]) is None: |
Ryan Tseng
2014/08/25 13:51:55
nit: if foo() is None: -> if not foo(): to match c
| |
89 self["trunk_revision"], | 89 self.Die("Failed to create deps for %s" % self["trunk_revision"]) |
90 deps) | |
91 TextToFile(deps, self.Config(DEPS_FILE)) | |
92 | 90 |
93 if self._options.reviewer and not self._options.manual: | 91 if self._options.reviewer and not self._options.manual: |
94 print "Using account %s for review." % self._options.reviewer | 92 print "Using account %s for review." % self._options.reviewer |
95 rev = self._options.reviewer | 93 rev = self._options.reviewer |
96 else: | 94 else: |
97 print "Please enter the email address of a reviewer for the roll CL: ", | 95 print "Please enter the email address of a reviewer for the roll CL: ", |
98 self.DieNoManualMode("A reviewer must be specified in forced mode.") | 96 self.DieNoManualMode("A reviewer must be specified in forced mode.") |
99 rev = self.ReadLine() | 97 rev = self.ReadLine() |
100 | 98 |
101 commit_title = "Update V8 to %s." % self["push_title"].lower() | 99 commit_title = "Update V8 to %s." % self["push_title"].lower() |
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
171 SwitchChromium, | 169 SwitchChromium, |
172 UpdateChromiumCheckout, | 170 UpdateChromiumCheckout, |
173 UploadCL, | 171 UploadCL, |
174 SwitchV8, | 172 SwitchV8, |
175 CleanUp, | 173 CleanUp, |
176 ] | 174 ] |
177 | 175 |
178 | 176 |
179 if __name__ == "__main__": # pragma: no cover | 177 if __name__ == "__main__": # pragma: no cover |
180 sys.exit(ChromiumRoll(CONFIG).Run()) | 178 sys.exit(ChromiumRoll(CONFIG).Run()) |
OLD | NEW |