Make GrGpuResources register with GrResourceCache2 after fully constructed.

Make GrGpuResources register with GrResourceCache2 after fully constructed.

Committed: https://skia.googlesource.com/skia/+/d68b3e491bb765beb7ca5e4ac8e0c80dedf5a83b

Committed: https://skia.googlesource.com/skia/+/169612621f00b3fe9f71014079991287d311751a

[bsalomon, 2014-08-26 18:29:19]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2014-08-26 18:29:19]

This will allow a subclass to populate a scratch key before the object is
inserted into GrRC2.

[robertphillips, 2014-08-26 18:49:25]

lgtm w/ nits/suggestions

https://codereview.chromium.org/504313002/diff/20001/include/gpu/GrGpuResource.h
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/504313002/diff/20001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResource.h:93: 
"by every GrGpuObject" -> "at the end of every GrGpuObject-derived class'
constructor" ?
object (typo)

https://codereview.chromium.org/504313002/diff/20001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResource.h:94: // This must be called by every GrGpuObject. It
should be called once the objet is fully
constructor (typo)

https://codereview.chromium.org/504313002/diff/20001/src/gpu/GrResourceCache2.h
File src/gpu/GrResourceCache2.h (right):

https://codereview.chromium.org/504313002/diff/20001/src/gpu/GrResourceCache2...
src/gpu/GrResourceCache2.h:36: #ifdef SK_DEBUG
const ?

[bsalomon, 2014-08-26 19:29:00]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-08-26 19:29:48]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/504313002/40001

[commit-bot: I haz the power, 2014-08-26 19:51:24]

Committed patchset #3 (40001) as d68b3e491bb765beb7ca5e4ac8e0c80dedf5a83b

[bsalomon, 2014-08-26 20:09:50]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/488463004/ by bsalomon@google.com.

The reason for reverting is: Breaking the bots.

[bsalomon, 2014-08-26 20:53:11]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-08-26 20:53:59]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/504313002/60001

[bsalomon, 2014-08-26 20:56:45]

forgot to publish before...

https://codereview.chromium.org/504313002/diff/20001/include/gpu/GrGpuResource.h
File include/gpu/GrGpuResource.h (right):

https://codereview.chromium.org/504313002/diff/20001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResource.h:93: 
On 2014/08/26 18:49:25, robertphillips wrote:
> "by every GrGpuObject" -> "at the end of every GrGpuObject-derived class'
> constructor" ?
> object (typo)

Hm, there are intermediate derived classes that shouldn't call this. That's why
I called out "fully constructed".

https://codereview.chromium.org/504313002/diff/20001/include/gpu/GrGpuResourc...
include/gpu/GrGpuResource.h:94: // This must be called by every GrGpuObject. It
should be called once the objet is fully
On 2014/08/26 18:49:25, robertphillips wrote:
> constructor (typo)

Done.

https://codereview.chromium.org/504313002/diff/20001/src/gpu/GrResourceCache2.h
File src/gpu/GrResourceCache2.h (right):

https://codereview.chromium.org/504313002/diff/20001/src/gpu/GrResourceCache2...
src/gpu/GrResourceCache2.h:36: #ifdef SK_DEBUG
On 2014/08/26 18:49:25, robertphillips wrote:
> const ?

Done.

[commit-bot: I haz the power, 2014-08-26 21:01:18]

Committed patchset #4 (60001) as 169612621f00b3fe9f71014079991287d311751a