Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: net/cert/ct_log_verifier_unittest.cc

Issue 503163002: Remove implicit conversions from scoped_refptr to T* in net/cert/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/crl_set_unittest.cc ('k') | net/cert/ct_objects_extractor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_log_verifier_unittest.cc
diff --git a/net/cert/ct_log_verifier_unittest.cc b/net/cert/ct_log_verifier_unittest.cc
index 9b3211df2e04400449bbd12f38e1e5999b5e0826..23cbf5166ce1ee98917386bab0189f74d5d7e262 100644
--- a/net/cert/ct_log_verifier_unittest.cc
+++ b/net/cert/ct_log_verifier_unittest.cc
@@ -36,7 +36,7 @@ TEST_F(CTLogVerifierTest, VerifiesCertSCT) {
scoped_refptr<ct::SignedCertificateTimestamp> cert_sct;
ct::GetX509CertSCT(&cert_sct);
- EXPECT_TRUE(log_->Verify(cert_entry, *cert_sct));
+ EXPECT_TRUE(log_->Verify(cert_entry, *cert_sct.get()));
}
TEST_F(CTLogVerifierTest, VerifiesPrecertSCT) {
@@ -46,7 +46,7 @@ TEST_F(CTLogVerifierTest, VerifiesPrecertSCT) {
scoped_refptr<ct::SignedCertificateTimestamp> precert_sct;
ct::GetPrecertSCT(&precert_sct);
- EXPECT_TRUE(log_->Verify(precert_entry, *precert_sct));
+ EXPECT_TRUE(log_->Verify(precert_entry, *precert_sct.get()));
}
TEST_F(CTLogVerifierTest, FailsInvalidTimestamp) {
@@ -59,7 +59,7 @@ TEST_F(CTLogVerifierTest, FailsInvalidTimestamp) {
// Mangle the timestamp, so that it should fail signature validation.
cert_sct->timestamp = base::Time::Now();
- EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct));
+ EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct.get()));
}
TEST_F(CTLogVerifierTest, FailsInvalidLogID) {
@@ -73,7 +73,7 @@ TEST_F(CTLogVerifierTest, FailsInvalidLogID) {
// attempting signature validation.
cert_sct->log_id.assign(cert_sct->log_id.size(), '\0');
- EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct));
+ EXPECT_FALSE(log_->Verify(cert_entry, *cert_sct.get()));
}
TEST_F(CTLogVerifierTest, SetsValidSTH) {
« no previous file with comments | « net/cert/crl_set_unittest.cc ('k') | net/cert/ct_objects_extractor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698