net/cert/ct_objects_extractor_unittest.cc - Issue 503163002: Remove implicit conversions from scoped_refptr to T* in net/cert/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/ct_objects_extractor_unittest.cc

Issue 503163002: Remove implicit conversions from scoped_refptr to T* in net/cert/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/ct_objects_extractor_unittest.cc

diff --git a/net/cert/ct_objects_extractor_unittest.cc b/net/cert/ct_objects_extractor_unittest.cc

index b229a478ae9e632480984092cca51af39b6a28e0..5feff3ef01a74abe6b85436b2e57944ea8512e25 100644

--- a/net/cert/ct_objects_extractor_unittest.cc

+++ b/net/cert/ct_objects_extractor_unittest.cc

@@ -107,7 +107,7 @@ TEST_F(CTObjectsExtractorTest, ExtractedSCTVerifies) {

precert_chain_[1]->os_cert_handle(),

&entry));

- EXPECT_TRUE(log_->Verify(entry, *sct));

+ EXPECT_TRUE(log_->Verify(entry, *sct.get()));

}

// Test that an externally-provided SCT verifies over the LogEntry

@@ -120,7 +120,7 @@ TEST_F(CTObjectsExtractorTest, ComplementarySCTVerifies) {

LogEntry entry;

ASSERT_TRUE(GetX509LogEntry(test_cert_->os_cert_handle(), &entry));

- EXPECT_TRUE(log_->Verify(entry, *sct));

+ EXPECT_TRUE(log_->Verify(entry, *sct.get()));

}

// Test that the extractor can parse OCSP responses.

« no previous file with comments | « net/cert/ct_log_verifier_unittest.cc ('k') | net/cert/multi_log_ct_verifier.cc » ('j') | no next file with comments »