Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: net/cert/crl_set_unittest.cc

Issue 503163002: Remove implicit conversions from scoped_refptr to T* in net/cert/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/crl_set_storage.cc ('k') | net/cert/ct_log_verifier_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/crl_set_unittest.cc
diff --git a/net/cert/crl_set_unittest.cc b/net/cert/crl_set_unittest.cc
index 76bd4c1563d6a872e80d12adf8d7e06aface64bb..16b3dfc324835ba5ad0fed1729c0ef6388da5192 100644
--- a/net/cert/crl_set_unittest.cc
+++ b/net/cert/crl_set_unittest.cc
@@ -223,10 +223,10 @@ TEST(CRLSetTest, NoOpDeltaUpdate) {
scoped_refptr<net::CRLSet> delta_set;
base::StringPiece delta(reinterpret_cast<const char*>(kNoopDeltaCRL),
sizeof(kNoopDeltaCRL));
- EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set, delta, &delta_set));
+ EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set.get(), delta, &delta_set));
ASSERT_TRUE(delta_set.get() != NULL);
- std::string out = net::CRLSetStorage::Serialize(delta_set);
+ std::string out = net::CRLSetStorage::Serialize(delta_set.get());
EXPECT_EQ(s.as_string(), out);
}
@@ -240,7 +240,7 @@ TEST(CRLSetTest, AddCRLDelta) {
scoped_refptr<net::CRLSet> delta_set;
base::StringPiece delta(reinterpret_cast<const char*>(kAddCRLDelta),
sizeof(kAddCRLDelta));
- EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set, delta, &delta_set));
+ EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set.get(), delta, &delta_set));
ASSERT_TRUE(delta_set.get() != NULL);
const net::CRLSet::CRLList& crls = delta_set->crls();
@@ -262,13 +262,14 @@ TEST(CRLSetTest, AddRemoveCRLDelta) {
scoped_refptr<net::CRLSet> delta_set;
base::StringPiece delta(reinterpret_cast<const char*>(kAddCRLDelta),
sizeof(kAddCRLDelta));
- EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set, delta, &delta_set));
+ EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set.get(), delta, &delta_set));
ASSERT_TRUE(delta_set.get() != NULL);
scoped_refptr<net::CRLSet> delta2_set;
base::StringPiece delta2(reinterpret_cast<const char*>(kRemoveCRLDelta),
sizeof(kRemoveCRLDelta));
- EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(delta_set, delta2, &delta2_set));
+ EXPECT_TRUE(
+ net::CRLSetStorage::ApplyDelta(delta_set.get(), delta2, &delta2_set));
ASSERT_TRUE(delta2_set.get() != NULL);
const net::CRLSet::CRLList& crls = delta2_set->crls();
@@ -287,7 +288,7 @@ TEST(CRLSetTest, UpdateSerialsDelta) {
scoped_refptr<net::CRLSet> delta_set;
base::StringPiece delta(reinterpret_cast<const char*>(kUpdateSerialsDelta),
sizeof(kUpdateSerialsDelta));
- EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set, delta, &delta_set));
+ EXPECT_TRUE(net::CRLSetStorage::ApplyDelta(set.get(), delta, &delta_set));
ASSERT_TRUE(delta_set.get() != NULL);
const net::CRLSet::CRLList& crls = delta_set->crls();
« no previous file with comments | « net/cert/crl_set_storage.cc ('k') | net/cert/ct_log_verifier_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698