Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 503113004: Remove implicit conversions from scoped_refptr to T* in net/socket/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in net/socket/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/08ea2af02ebddfe56657e8756d6d946a590c1e39 Cr-Commit-Position: refs/heads/master@{#291788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -55 lines) Patch
M net/socket/socket_libevent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_socket_libevent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/unix_domain_client_socket_posix_unittest.cc View 10 chunks +29 lines, -34 lines 0 comments Download
M net/socket/unix_domain_server_socket_posix_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + ttuttle@chromium.org
6 years, 4 months ago (2014-08-25 21:27:41 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 4 months ago (2014-08-25 21:29:56 UTC) #2
Deprecated (see juliatuttle)
lgtm
6 years, 4 months ago (2014-08-25 21:33:19 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 4 months ago (2014-08-25 21:34:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/503113004/1
6 years, 4 months ago (2014-08-25 21:35:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 22:47:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as c5f3935c4604859d8915cd61bc9e208b7dc2700f
6 years, 4 months ago (2014-08-25 23:38:31 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08ea2af02ebddfe56657e8756d6d946a590c1e39
Cr-Commit-Position: refs/heads/master@{#291788}

Powered by Google App Engine
This is Rietveld 408576698