net/socket/ssl_server_socket_unittest.cc - Issue 503113004: Remove implicit conversions from scoped_refptr to T* in net/socket/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_server_socket_unittest.cc

Issue 503113004: Remove implicit conversions from scoped_refptr to T* in net/socket/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_server_socket_unittest.cc

diff --git a/net/socket/ssl_server_socket_unittest.cc b/net/socket/ssl_server_socket_unittest.cc

index 79d5a7fd1eb0fdae53c000896d5adfa5f12e3610..e9b599ab238a96f7253ab8b2b55de568eb15c437 100644

--- a/net/socket/ssl_server_socket_unittest.cc

+++ b/net/socket/ssl_server_socket_unittest.cc

@@ -63,7 +63,7 @@ class FakeDataChannel {

int Read(IOBuffer* buf, int buf_len, const CompletionCallback& callback) {

DCHECK(read_callback_.is_null());

- DCHECK(!read_buf_);

+ DCHECK(!read_buf_.get());

if (closed_)

return 0;

if (data_.empty()) {

« no previous file with comments | « net/socket/ssl_client_socket_unittest.cc ('k') | net/socket/tcp_socket_libevent.cc » ('j') | no next file with comments »