Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: net/socket/socket_test_util.cc

Issue 503113004: Remove implicit conversions from scoped_refptr to T* in net/socket/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socket_libevent.cc ('k') | net/socket/ssl_client_socket_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index b847a2994d7a601f64578e5434f9395bd932b409..a709060612d4b3026f74160920c0a7278009c095 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -857,7 +857,7 @@ int MockTCPClientSocket::Read(IOBuffer* buf, int buf_len,
return ERR_UNEXPECTED;
// If the buffer is already in use, a read is already in progress!
- DCHECK(pending_buf_ == NULL);
+ DCHECK(pending_buf_.get() == NULL);
// Store our async IO data.
pending_buf_ = buf;
@@ -965,7 +965,7 @@ bool MockTCPClientSocket::GetSSLInfo(SSLInfo* ssl_info) {
void MockTCPClientSocket::OnReadComplete(const MockRead& data) {
// There must be a read pending.
- DCHECK(pending_buf_);
+ DCHECK(pending_buf_.get());
// You can't complete a read with another ERR_IO_PENDING status code.
DCHECK_NE(ERR_IO_PENDING, data.result);
// Since we've been waiting for data, need_read_data_ should be true.
@@ -989,7 +989,7 @@ void MockTCPClientSocket::OnConnectComplete(const MockConnect& data) {
}
int MockTCPClientSocket::CompleteRead() {
- DCHECK(pending_buf_);
+ DCHECK(pending_buf_.get());
DCHECK(pending_buf_len_ > 0);
was_used_to_convey_data_ = true;
@@ -1560,7 +1560,7 @@ int MockUDPClientSocket::Read(IOBuffer* buf,
return ERR_UNEXPECTED;
// If the buffer is already in use, a read is already in progress!
- DCHECK(pending_buf_ == NULL);
+ DCHECK(pending_buf_.get() == NULL);
// Store our async IO data.
pending_buf_ = buf;
@@ -1637,7 +1637,7 @@ int MockUDPClientSocket::Connect(const IPEndPoint& address) {
void MockUDPClientSocket::OnReadComplete(const MockRead& data) {
// There must be a read pending.
- DCHECK(pending_buf_);
+ DCHECK(pending_buf_.get());
// You can't complete a read with another ERR_IO_PENDING status code.
DCHECK_NE(ERR_IO_PENDING, data.result);
// Since we've been waiting for data, need_read_data_ should be true.
@@ -1660,7 +1660,7 @@ void MockUDPClientSocket::OnConnectComplete(const MockConnect& data) {
}
int MockUDPClientSocket::CompleteRead() {
- DCHECK(pending_buf_);
+ DCHECK(pending_buf_.get());
DCHECK(pending_buf_len_ > 0);
// Save the pending async IO data and reset our |pending_| state.
« no previous file with comments | « net/socket/socket_libevent.cc ('k') | net/socket/ssl_client_socket_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698