Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 502853002: Mojom: Blanket change to mark all pointer/handle fields as nullable. (Closed)

Created:
6 years, 3 months ago by yzshen1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojom: Blanket change to mark all pointer/handle fields as nullable. The purpose is to make those APIs have the same semantics as before. And then we can selectively turn fields into non-nullable. Mojom files that are not included in this change: - surface-related files: the owner (jamesr) has landed some non-nullable fixes. It is possible that he has fully reviewed them. (I will confirm with him.) - test files: have been examined. BUG=324170 TEST=None Committed: https://crrev.com/7182448c92676e62ee5f19be1545de7a86eae012 Cr-Commit-Position: refs/heads/master@{#291862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -87 lines) Patch
M content/common/render_frame_setup.mojom View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_stream.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/serial.mojom View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/application_manager/test.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/echo/echo_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/window_manager/window_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/application/application.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/application/service_provider.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/application/shell.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/dbus_echo/echo.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gles2/command_buffer.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/interfaces/geometry/geometry.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/gpu/gpu.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/launcher/launcher.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/services/public/interfaces/network/cookie_store.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/network/network_error.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/network/network_service.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 3 chunks +13 lines, -13 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 9 chunks +16 lines, -14 lines 0 comments Download
M mojo/services/test_service/test_request_tracker.mojom View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/services/test_service/test_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/app_child_process.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/external_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/spy/public/spy.mojom View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/keyboard/webui/keyboard.mojom View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yzshen1
Hi, Darin. I spent some miserable time inspecting the mojom files and corresponding code, trying ...
6 years, 3 months ago (2014-08-25 04:11:06 UTC) #1
darin (slow to review)
OK, LGTM We'll surely have a round of API review before it is all set ...
6 years, 3 months ago (2014-08-25 18:17:12 UTC) #2
yzshen1
On 2014/08/25 18:17:12, darin wrote: > OK, LGTM > > We'll surely have a round ...
6 years, 3 months ago (2014-08-25 18:22:53 UTC) #3
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 3 months ago (2014-08-26 06:24:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/502853002/1
6 years, 3 months ago (2014-08-26 06:26:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-26 07:09:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as c9237148b4c572e76e6eb7364be437bb00adfc8d
6 years, 3 months ago (2014-08-26 07:45:38 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:41:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7182448c92676e62ee5f19be1545de7a86eae012
Cr-Commit-Position: refs/heads/master@{#291862}

Powered by Google App Engine
This is Rietveld 408576698