Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: mojo/services/public/interfaces/navigation/navigation.mojom

Issue 502853002: Mojom: Blanket change to mark all pointer/handle fields as nullable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/interfaces/navigation/navigation.mojom
diff --git a/mojo/services/public/interfaces/navigation/navigation.mojom b/mojo/services/public/interfaces/navigation/navigation.mojom
index dc565c307edb5c3c1b925ec7da9de56c2b5a4bb5..7e2e150751810b544248ed5794a0c9e930d9ab7c 100644
--- a/mojo/services/public/interfaces/navigation/navigation.mojom
+++ b/mojo/services/public/interfaces/navigation/navigation.mojom
@@ -21,28 +21,28 @@ enum Target {
struct NavigationDetails {
// TODO(mpcomplete): will we ever need more than the URLRequest? Can
// we pass that around directly?
- URLRequest request = default;
+ URLRequest? request = default;
};
struct ResponseDetails {
// TODO(beng): consider providing access to URLRequest too. Currently it is
// not possible to obtain from the URLLoader.
- URLResponse response;
+ URLResponse? response;
// The URLLoader instance that generated the response. This must be kept
// alive until the response body has been completely consumed.
- URLLoader loader;
+ URLLoader? loader;
};
// Embedders that support navigation of implement this interface.
interface NavigatorHost {
RequestNavigate(uint32 source_node_id, Target target,
- NavigationDetails details);
+ NavigationDetails? details);
// Applications call this to inform hosts of navigations they performed
// locally. For example, pushState() navigations in an HTML application.
- DidNavigateLocally(uint32 source_node_id, string url);
+ DidNavigateLocally(uint32 source_node_id, string? url);
};
// Applications implement this interface to support navigation of their views
@@ -51,8 +51,8 @@ interface NavigatorHost {
// network load.
interface Navigator {
Navigate(uint32 node_id,
- NavigationDetails navigation_details,
- ResponseDetails response_details);
+ NavigationDetails? navigation_details,
+ ResponseDetails? response_details);
};
}

Powered by Google App Engine
This is Rietveld 408576698