Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: mojo/services/test_service/test_request_tracker.mojom

Issue 502853002: Mojom: Blanket change to mark all pointer/handle fields as nullable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/test_service/test_request_tracker.mojom
diff --git a/mojo/services/test_service/test_request_tracker.mojom b/mojo/services/test_service/test_request_tracker.mojom
index d69e139ae8203aa0de24189cb3dc530d86b89c56..ae541b95a97741be0c9b677fedf9671825a327c7 100644
--- a/mojo/services/test_service/test_request_tracker.mojom
+++ b/mojo/services/test_service/test_request_tracker.mojom
@@ -14,7 +14,7 @@ struct ServiceStats {
// A per-service summary of all the ServiceStats the
// TestTrackedRequestService has observed.
struct ServiceReport {
- string service_name;
+ string? service_name;
uint64 total_requests;
double mean_health;
};
@@ -22,7 +22,7 @@ struct ServiceReport {
// A simple interface to obtain a "report" from all services that have
// opted to connect themselves to for request tracking.
interface TestTrackedRequestService {
- GetReport() => (ServiceReport[] report);
+ GetReport() => (ServiceReport?[]? report);
};
// TestRequestTracker records ServiceStats for an individual service
@@ -30,14 +30,14 @@ interface TestTrackedRequestService {
[Client=TestRequestTrackerClient]
interface TestRequestTracker {
// Upload a ServiceStats for tracking.
- RecordStats(uint64 client_id, ServiceStats stats);
+ RecordStats(uint64 client_id, ServiceStats? stats);
};
// The client-side contract for uploading ServiceStats to TestRequestTracker.
interface TestRequestTrackerClient {
const uint64 kInvalidId = 0;
// Handshake to tell the client its global identifier and get the name.
- SetIdAndReturnName(uint64 id) => (string service_name);
+ SetIdAndReturnName(uint64 id) => (string? service_name);
};
} // module mojo.test
« no previous file with comments | « mojo/services/public/interfaces/view_manager/view_manager.mojom ('k') | mojo/services/test_service/test_service.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698