content/browser/devtools/devtools_manager_unittest.cc - Issue 502203002: Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_manager_unittest.cc

Issue 502203002: Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/browser/devtools/embedded_worker_devtools_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_manager_unittest.cc

diff --git a/content/browser/devtools/devtools_manager_unittest.cc b/content/browser/devtools/devtools_manager_unittest.cc

index 25a0ba4d9e60aca3ef44d0e5ea4404ab157c80b8..b4984e648268d3c864adf676f551b60b302c5e2f 100644

--- a/content/browser/devtools/devtools_manager_unittest.cc

+++ b/content/browser/devtools/devtools_manager_unittest.cc

@@ -175,7 +175,7 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {

url2, Referrer(), PAGE_TRANSITION_TYPED, std::string());

EXPECT_TRUE(contents()->cross_navigation_pending());

EXPECT_EQ(client_host.agent_host(),

- DevToolsAgentHost::GetOrCreateFor(web_contents()));

+ DevToolsAgentHost::GetOrCreateFor(web_contents()).get());

// Interrupt pending navigation and navigate back to the original site.

controller().LoadURL(

@@ -184,7 +184,7 @@ TEST_F(DevToolsManagerTest, ReattachOnCancelPendingNavigation) {

contents()->GetMainFrame(), 1, url, PAGE_TRANSITION_TYPED);

EXPECT_FALSE(contents()->cross_navigation_pending());

EXPECT_EQ(client_host.agent_host(),

- DevToolsAgentHost::GetOrCreateFor(web_contents()));

+ DevToolsAgentHost::GetOrCreateFor(web_contents()).get());

client_host.Close();

}