Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 502203002: Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index 72fe254a23be241c5b05b3f6549bf84097b99814..cd64c3cb35612e6b64062689cc3c2b975d50332d 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -83,7 +83,7 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient {
}
virtual ~DevToolsAgentHostClientImpl() {
- if (agent_host_)
+ if (agent_host_.get())
agent_host_->DetachClient();
}
@@ -125,7 +125,7 @@ class DevToolsAgentHostClientImpl : public DevToolsAgentHostClient {
}
void OnMessage(const std::string& message) {
- if (agent_host_)
+ if (agent_host_.get())
agent_host_->DispatchProtocolMessage(message);
}
@@ -608,7 +608,7 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequestUI(
DevToolsTarget* target = GetTarget(page_id);
scoped_refptr<DevToolsAgentHost> agent =
target ? target->GetAgentHost() : NULL;
- if (!agent) {
+ if (!agent.get()) {
Send500(connection_id, "No such target id: " + page_id);
return;
}
@@ -619,8 +619,8 @@ void DevToolsHttpHandlerImpl::OnWebSocketRequestUI(
return;
}
- DevToolsAgentHostClientImpl * client_host = new DevToolsAgentHostClientImpl(
- thread_->message_loop(), server_.get(), connection_id, agent);
+ DevToolsAgentHostClientImpl* client_host = new DevToolsAgentHostClientImpl(
+ thread_->message_loop(), server_.get(), connection_id, agent.get());
connection_to_client_ui_[connection_id] = client_host;
AcceptWebSocket(connection_id, request);
« no previous file with comments | « content/browser/devtools/devtools_browser_target.cc ('k') | content/browser/devtools/devtools_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698