content/browser/devtools/embedded_worker_devtools_manager_unittest.cc - Issue 502203002: Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

Issue 502203002: Remove implicit conversions from scoped_refptr to T* in content/browser/devtools/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_manager_unittest.cc ('k') | content/browser/devtools/render_view_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

diff --git a/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc b/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

index 04107a3343bd52635184ea2a44e73af32db6ceca..2159fb4ba51c79101b5c7633a8f6b65e83338a3e 100644

--- a/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

+++ b/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc

@@ -28,10 +28,10 @@ class TestDevToolsClientHost : public DevToolsAgentHostClient {

DevToolsAgentHost* agent_host, bool replaced) OVERRIDE {}

void InspectAgentHost(DevToolsAgentHost* agent_host) {

- if (agent_host_)

+ if (agent_host_.get())

agent_host_->DetachClient();

agent_host_ = agent_host;

- if (agent_host_)

+ if (agent_host_.get())

agent_host_->AttachClient(this);

}

private:

@@ -232,7 +232,7 @@ TEST_F(EmbeddedWorkerDevToolsManagerTest, AttachTest) {

EXPECT_NE(agent_host1.get(), agent_host2.get());

EXPECT_EQ(agent_host2.get(), manager_->GetDevToolsAgentHostForWorker(2, 2));

CheckWorkerState(2, 2, WorkerState::WORKER_UNINSPECTED);

- client_host2->InspectAgentHost(agent_host2);

+ client_host2->InspectAgentHost(agent_host2.get());

CheckWorkerState(2, 2, WorkerState::WORKER_INSPECTED);

manager_->WorkerDestroyed(2, 2);

CheckWorkerState(2, 2, WorkerState::WORKER_TERMINATED);