Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 502163003: Remove implicit conversions from scoped_refptr to T* in net/http/ (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, rvargas (doing something else)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in net/http/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/48459ac2153ce3e4512fccff9825b705952c5d77 Cr-Commit-Position: refs/heads/master@{#291815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -101 lines) Patch
M net/http/disk_based_cert_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/disk_based_cert_cache_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M net/http/disk_cache_based_quic_server_info.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 82 chunks +84 lines, -85 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/transport_security_persister.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + rtenneti@chromium.org
6 years, 4 months ago (2014-08-25 21:23:09 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 4 months ago (2014-08-25 21:30:01 UTC) #2
ramant (doing other things)
lgtm
6 years, 4 months ago (2014-08-25 23:54:21 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 4 months ago (2014-08-25 23:55:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/502163003/1
6 years, 4 months ago (2014-08-25 23:56:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 38fe0b24f87c26df0edce7af512618054f5a50a2
6 years, 4 months ago (2014-08-26 00:46:53 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:39:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48459ac2153ce3e4512fccff9825b705952c5d77
Cr-Commit-Position: refs/heads/master@{#291815}

Powered by Google App Engine
This is Rietveld 408576698