net/http/disk_based_cert_cache_unittest.cc - Issue 502163003: Remove implicit conversions from scoped_refptr to T* in net/http/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/disk_based_cert_cache_unittest.cc

Issue 502163003: Remove implicit conversions from scoped_refptr to T* in net/http/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/disk_based_cert_cache_unittest.cc

diff --git a/net/http/disk_based_cert_cache_unittest.cc b/net/http/disk_based_cert_cache_unittest.cc

index 835df194c5d6a27fd8db3bc7c49a669504348f50..584cae24cbc6f9488ea0e3d534aa2e89c042063b 100644

--- a/net/http/disk_based_cert_cache_unittest.cc

+++ b/net/http/disk_based_cert_cache_unittest.cc

@@ -144,7 +144,7 @@ void ImportCert(disk_cache::Backend* backend,

memcpy(buffer->data(), write_data.data(), write_data.size());

rv = entry->WriteData(0 /* index */,

0 /* offset */,

- buffer,

+ buffer.get(),

write_data.size(),

callback.callback(),

true /* truncate */);

@@ -168,8 +168,11 @@ void CheckCertCached(disk_cache::Backend* backend,

ASSERT_TRUE(encoded);

int entry_size = entry->GetDataSize(0 /* index */);

scoped_refptr<IOBuffer> buffer(new IOBuffer(entry_size));

- rv = entry->ReadData(

- 0 /* index */, 0 /* offset */, buffer, entry_size, callback.callback());

+ rv = entry->ReadData(0 /* index */,

+ 0 /* offset */,

+ buffer.get(),

+ entry_size,

+ callback.callback());

EXPECT_EQ(entry_size, callback.GetResult(rv));

entry->Close();

X509Certificate::OSCertHandle cached_cert_handle =

« no previous file with comments | « net/http/disk_based_cert_cache.cc ('k') | net/http/disk_cache_based_quic_server_info.cc » ('j') | no next file with comments »