net/http/http_stream_parser_unittest.cc - Issue 502163003: Remove implicit conversions from scoped_refptr to T* in net/http/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_parser_unittest.cc

Issue 502163003: Remove implicit conversions from scoped_refptr to T* in net/http/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_stream_parser_unittest.cc

diff --git a/net/http/http_stream_parser_unittest.cc b/net/http/http_stream_parser_unittest.cc

index 33910395cbcaabad9689498a2696be47c211633f..8e7486f7386245976d6428a465921b9447240b39 100644

--- a/net/http/http_stream_parser_unittest.cc

+++ b/net/http/http_stream_parser_unittest.cc

@@ -555,7 +555,8 @@ class SimpleGetRunner {

int rv;

int i = 0;

while (true) {

- rv = parser_->ReadResponseBody(buffer, user_buf_len, callback.callback());

+ rv = parser_->ReadResponseBody(

+ buffer.get(), user_buf_len, callback.callback());

EXPECT_EQ(read_lengths[i], rv);

i++;

if (rv <= 0)

« no previous file with comments | « net/http/http_stream_factory_impl_request_unittest.cc ('k') | net/http/transport_security_persister.cc » ('j') | no next file with comments »